Page MenuHomePhabricator
Differential D3016

build: Remove -I for everything but project root
ClosedPublic
Actions

Authored by Fabien on May 10 2019, 09:55.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING99eb5a8bff6d: build: Remove -I for everything but project root
rABC99eb5a8bff6d: build: Remove -I for everything but project root
Summary

Remove -I from build system for everything but the project root,
and built-in dependencies.

Partial backport of core PR11651 (commit 0c71521)
https://github.com/bitcoin/bitcoin/pull/11651/commits/0c715214dd2d03b66a366a87bf6d2c576c0176c2

Completes T649

Test Plan
make check
ninja check
ninja bitcoin-bench

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.May 10 2019, 09:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 10 2019, 09:55
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.May 10 2019, 09:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 10 2019, 10:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5797: Diff 8586.May 10 2019, 10:10
jasonbcox accepted this revision.May 10 2019, 16:35
This revision is now accepted and ready to land.May 10 2019, 16:35
Closed by commit rABC99eb5a8bff6d: build: Remove -I for everything but project root (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by Fabien). · Explain WhyMay 12 2019, 05:39
This revision was automatically updated to reflect the committed changes.
Fabien mentioned this in D3030: [CMAKE] Fix missing protobuf include directory.May 13 2019, 08:06
Fabien mentioned this in rABC116f9831e6c5: [CMAKE] Fix missing protobuf include directory.May 16 2019, 07:26
Fabien added a commit: rSTAGING99eb5a8bff6d: build: Remove -I for everything but project root.Sep 18 2019, 23:29
Fabien mentioned this in rSTAGING116f9831e6c5: [CMAKE] Fix missing protobuf include directory.Sep 18 2019, 23:33

Revision Contents
Changeset List

PathSize
src/
2 lines
3 lines
2 lines
bench/
2 lines
qt/
8 lines
test/
6 lines

Diff 8616

View Options

src/Makefile.am

Loading...
View Options

src/Makefile.qt.include

Loading...
View Options

src/Makefile.test.include

Loading...
View Options

src/bench/CMakeLists.txt

Loading...
View Options

src/qt/CMakeLists.txt

Loading...
View Options

src/test/CMakeLists.txt

Loading...