Page MenuHomePhabricator
Differential D3054

Fix boost::thread::interruption_point causing build failure on Windows
ClosedPublic
Actions

Authored by Fabien on May 15 2019, 15:50.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING610f36bf9772: Fix boost::thread::interruption_point causing build failure on Windows
rABC610f36bf9772: Fix boost::thread::interruption_point causing build failure on Windows
Summary

Revert some of the changes from D3042.

Test Plan

Run Gitian build for windows

Diff Detail

Repository
rABC Bitcoin ABC
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5863
Build 9786: Bitcoin ABC Buildbot (legacy)
Build 9785: arc lint + arc unit

Event Timeline

Fabien created this revision.May 15 2019, 15:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 15 2019, 15:50
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.May 15 2019, 15:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5863: Diff 8679.May 15 2019, 16:06
teamcity added a comment.May 15 2019, 16:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox accepted this revision.May 15 2019, 17:16
jasonbcox added a subscriber: jasonbcox.

Nit: comment these as needed on Windows

This revision is now accepted and ready to land.May 15 2019, 17:16
Fabien updated this revision to Diff 8680.May 15 2019, 19:53

Comment on boost/thread use.

teamcity added a comment.May 15 2019, 19:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 15 2019, 20:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5864: Diff 8680.May 15 2019, 20:08
Closed by commit rABC610f36bf9772: Fix boost::thread::interruption_point causing build failure on Windows (authored by Fabien). · Explain WhyMay 15 2019, 20:15
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rSTAGING610f36bf9772: Fix boost::thread::interruption_point causing build failure on Windows.Sep 18 2019, 23:32

Revision Contents
Changeset List

PathSize
src/
2 lines
1 line
wallet/
1 line

Diff 8679

View Options

src/txdb.cpp

Loading...
View Options

src/validation.cpp

Loading...
View Options

src/wallet/db.cpp

Loading...