Clarify comment for SCRIPT_ENABLE_CHECKDATASIG
ClosedPublic
Actions

Authored by Mengerian on May 16 2019, 20:35.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Maniphest Tasks

T653: Clean up past upgrades

Commits

rSTAGINGcaec57fc9566: Clarify comment for SCRIPT_ENABLE_CHECKDATASIG
rABCcaec57fc9566: Clarify comment for SCRIPT_ENABLE_CHECKDATASIG

Summary

The important function of the flag, now that it is activated,
is to flag when it should be counted towards the sigops limit.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5875
Build 9810: Bitcoin ABC Buildbot (legacy)
Build 9809: arc lint + arc unit

Event Timeline

Mengerian created this revision.May 16 2019, 20:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 16 2019, 20:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Mengerian added a task: T653: Clean up past upgrades.May 16 2019, 20:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5875: Diff 8702.May 16 2019, 20:50

deadalnix accepted this revision.May 16 2019, 22:56

This revision is now accepted and ready to land.May 16 2019, 22:56

Closed by commit rABCcaec57fc9566: Clarify comment for SCRIPT_ENABLE_CHECKDATASIG (authored by Mengerian). · Explain WhyMay 17 2019, 00:20

This revision was automatically updated to reflect the committed changes.

Mengerian added a commit: rSTAGINGcaec57fc9566: Clarify comment for SCRIPT_ENABLE_CHECKDATASIG.Sep 18 2019, 23:35

Revision Contents
Changeset List

Path

Size

src/

script/

script_flags.h

3 lines

Diff 8702

View Options

Clarify comment for SCRIPT_ENABLE_CHECKDATASIGClosedPublicActions