Merge #12564: [arith_uint256] Avoid unnecessary this-copy using prefix operator
ClosedPublic
Actions

Authored by nakihito on May 17 2019, 20:34.

Details

Reviewers

jasonbcox
deadalnix
Fabien
markblundeberg

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING1fc4b4a46602: Merge #12564: [arith_uint256] Avoid unnecessary this-copy using prefix operator
rABC1fc4b4a46602: Merge #12564: [arith_uint256] Avoid unnecessary this-copy using prefix operator

Summary

22b4aae02 [arith_uint256] Avoid unnecessary this-copy using prefix operator (Karl-Johan Alm)

Pull request description:

I noticed while profiling a related project that `operator-()` actually calls the `base_uint` constructor, which is because the postfix operator version of `operator++` (used in `operator-()`) creates a copy of `this` and returns it.

Tree-SHA512: d9a2665caa3d93f064cdeaf1c6fada101b9943bb53d93ccac6d9a0edac20279d2e921349e30239039c71e0a9629e45c29ec9f10d8d7499e936cdba6cb7c3c3eb

Backport of Core PR 12564
https://github.com/bitcoin/bitcoin/pull/12564

Test Plan

make check
test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.May 17 2019, 20:34

Owners added a reviewer: Restricted Owners Package.May 17 2019, 20:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 17 2019, 20:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5889: Diff 8727.May 17 2019, 20:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien accepted this revision.May 18 2019, 05:17

This revision is now accepted and ready to land.May 18 2019, 05:17

Closed by commit rABC1fc4b4a46602: Merge #12564: [arith_uint256] Avoid unnecessary this-copy using prefix operator (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyMay 20 2019, 21:18

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rSTAGING1fc4b4a46602: Merge #12564: [arith_uint256] Avoid unnecessary this-copy using prefix operator.Sep 18 2019, 23:37

Revision Contents
Changeset List

Path

Size

src/

arith_uint256.h

2 lines

Diff 8756

View Options

Merge #12564: [arith_uint256] Avoid unnecessary this-copy using prefix operatorClosedPublicActions