Page MenuHomePhabricator
Differential D3101

[rpc] Add initialblockdownload to getblockchaininfo
ClosedPublic
Actions

Authored by markblundeberg on May 23 2019, 23:17.

Details

Reviewers
jasonbcox
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING2066871d6b54: [rpc] Add initialblockdownload to getblockchaininfo
rABC2066871d6b54: [rpc] Add initialblockdownload to getblockchaininfo
Summary

PR11258 backport https://github.com/bitcoin/bitcoin/pull/11258/files

Just first commit; I'm omitting the second commit which just does
inapplicable reformatting. Also, modified to use pushKV.

Includes release notes copied from Core release-notes-0.16.0.md

Test Plan

make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11258
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5959
Build 9978: Bitcoin ABC Buildbot (legacy)
Build 9977: arc lint + arc unit

Event Timeline

markblundeberg created this revision.May 23 2019, 23:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 23 2019, 23:17
Herald added a reviewer: deadalnix. · View Herald Transcript
markblundeberg planned changes to this revision.May 23 2019, 23:18
teamcity added a comment.May 23 2019, 23:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added a comment.May 23 2019, 23:18

oops, obviously should use pushKV here!

markblundeberg updated this revision to Diff 8837.May 23 2019, 23:30
markblundeberg edited the summary of this revision. (Show Details)

use pushKV

teamcity added a comment.May 23 2019, 23:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5958: Diff 8836.May 23 2019, 23:33
teamcity added a comment.May 23 2019, 23:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

teamcity added a comment.May 23 2019, 23:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5959: Diff 8837.May 23 2019, 23:45
jasonbcox requested changes to this revision.May 24 2019, 00:49

Add an item in the release notes.

Looks good otherwise.

This revision now requires changes to proceed.May 24 2019, 00:49
markblundeberg mentioned this in D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.May 24 2019, 01:28
markblundeberg updated this revision to Diff 8840.May 24 2019, 02:09
markblundeberg edited the summary of this revision. (Show Details)

rebase; release notes

teamcity added a comment.May 24 2019, 02:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 24 2019, 02:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5961: Diff 8840.May 24 2019, 02:24
Fabien accepted this revision.May 24 2019, 06:48
jasonbcox accepted this revision.May 24 2019, 16:23
This revision is now accepted and ready to land.May 24 2019, 16:23
Closed by commit rABC2066871d6b54: [rpc] Add initialblockdownload to getblockchaininfo (authored by John Newbery <john@johnnewbery.com>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyMay 24 2019, 16:33
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABC2066871d6b54: [rpc] Add initialblockdownload to getblockchaininfo.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING2066871d6b54: [rpc] Add initialblockdownload to getblockchaininfo.Sep 18 2019, 23:43

Revision Contents
Changeset List

PathSize
src/
rpc/
3 lines
test/
functional/
2 lines

Diff 8837

View Options

src/rpc/blockchain.cpp

Loading...
View Options

test/functional/rpc_blockchain.py

Loading...