Page MenuHomePhabricator

Merge #10308: [wallet] Securely erase potentially sensitive keys/values
ClosedPublic

Authored by jasonbcox on May 24 2019, 19:42.

Details

Summary

6c914ac [wallet] Securely erase potentially sensitive keys/values (Thomas Snider)

Tree-SHA512: 071d88c4093108d4e4eced35a6ffcebe3f499798194f5b1be661ffa5b78b5f55311667f6d2a72758d85290f61f958381ee95d380b9045ca18e9e1875f0e686c8

Backport Core PR10308
https://github.com/bitcoin/bitcoin/pull/10308/files

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10308
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5975
Build 10010: Bitcoin ABC Buildbot (legacy)
Build 10009: arc lint + arc unit

Event Timeline

markblundeberg added a subscriber: markblundeberg.

Cool! TIL memset 0 is not necessarily good enough.

From the PR discussion it sounds like this doesn't guarantee much on its own, but presumably you'll be backporting PR11196 soon as well. :-)

This revision is now accepted and ready to land.May 24 2019, 21:17