This is a partial backport of Core PR11116 : https://github.com/bitcoin/bitcoin/pull/11116/commits/d7afe2d1577eb3f6775301c81b94a191e0db99d9
Details
Details
- Reviewers
markblundeberg - Group Reviewers
Restricted Project - Commits
- rSTAGINGcf54664b876c: [script] Unit tests for script/standard functions
rABCcf54664b876c: [script] Unit tests for script/standard functions
make check
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| src/test/script_standard_tests.cpp | ||
|---|---|---|
| 91 ↗ | (On Diff #8881) | This is good, it would be awful it we had to start supporting bech32 recoveries as well! :D |
| src/test/script_standard_tests.cpp | ||
|---|---|---|
| 91 ↗ | (On Diff #8881) | (However maybe these should be moved out from the script_standard_Solver_success test) |
| src/test/script_standard_tests.cpp | ||
|---|---|---|
| 91 ↗ | (On Diff #8881) | Unless you volunteer to maintain it, I don't think it's a good idea. |
| src/test/script_standard_tests.cpp | ||
|---|---|---|
| 91 ↗ | (On Diff #8881) | OK, can we add a comment or something? Just looks weird having failure tests in success section. |
| 113 ↗ | (On Diff #8881) | This is not in original PR nor does Core have it in current file. But it does appear to make sense here. |
| 227 ↗ | (On Diff #8881) | An erroneous test per Wuille's comment -- https://github.com/bitcoin/bitcoin/pull/11116#discussion_r140642842 |
| 303 ↗ | (On Diff #8881) | also erroneous P2WSH... |