Page MenuHomePhabricator
Differential D3132

Implicitly know about P2WPKH redeemscripts
ClosedPublic
Actions

Authored by deadalnix on May 27 2019, 16:25.

Details

Reviewers
markblundeberg
Group Reviewers
Restricted Project
Commits
rSTAGING588be01e6b9f: Implicitly know about P2WPKH redeemscripts
rABC588be01e6b9f: Implicitly know about P2WPKH redeemscripts
Summary

Make CKeyStore automatically known about the redeemscripts necessary for P2SH-P2WPKH
(and due to the extra checks in IsMine, also P2WPKH) spending.

This is a partial backport of Core PR11403 : https://github.com/bitcoin/bitcoin/pull/11403/commits/f37c64e477d679853a4076f2f7888568bb034e90

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
implicitsw
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6018
Build 10095: Bitcoin ABC Buildbot (legacy)
Build 10094: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 27 2019, 16:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 27 2019, 16:25
teamcity added a comment.May 27 2019, 16:25

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 27 2019, 16:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6018: Diff 8931.May 27 2019, 16:39
deadalnix added a child revision: D3133: SegWit wallet support.May 27 2019, 18:31
markblundeberg requested changes to this revision.May 27 2019, 22:31
markblundeberg added a subscriber: markblundeberg.
markblundeberg added inline comments.
src/keystore.cpp
29

fix typo: riht -> right

This revision now requires changes to proceed.May 27 2019, 22:31
deadalnix updated this revision to Diff 8943.May 27 2019, 22:59

Fix typo

teamcity added a comment.May 27 2019, 22:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg accepted this revision.May 27 2019, 23:13
This revision is now accepted and ready to land.May 27 2019, 23:13
teamcity added a comment.May 27 2019, 23:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6027: Diff 8943.May 27 2019, 23:13
Closed by commit rABC588be01e6b9f: Implicitly know about P2WPKH redeemscripts (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyMay 28 2019, 00:02
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC588be01e6b9f: Implicitly know about P2WPKH redeemscripts.
deadalnix added a commit: rSTAGING588be01e6b9f: Implicitly know about P2WPKH redeemscripts.Sep 18 2019, 23:49

Revision Contents
Changeset List

PathSize
src/
2 lines
20 lines
wallet/
1 line

Diff 8931

View Options

src/keystore.h

Loading...
View Options

src/keystore.cpp

Loading...
View Options

src/wallet/crypter.cpp

Loading...