Page MenuHomePhabricator
Differential D3137

Simplify "bool x = y ? true : false". Remove unused function and trailing semicolon.
ClosedPublic
Actions

Authored by deadalnix on May 27 2019, 22:34.

Details

Reviewers
markblundeberg
Group Reviewers
Restricted Project
Commits
rSTAGING0856db8ae051: Simplify "bool x = y ? true : false". Remove unused function and trailing…
rABC0856db8ae051: Simplify "bool x = y ? true : false". Remove unused function and trailing…
Summary
  • [tests] Remove unused function InsecureRandBytes(size_t len)
  • Simplify "bool x = y ? true : false" to "bool x = y"

This is a backport of Core PR10553

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10553
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6025
Build 10109: Bitcoin ABC Buildbot (legacy)
Build 10108: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 27 2019, 22:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 27 2019, 22:34
teamcity added a comment.May 27 2019, 22:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix updated this revision to Diff 8941.May 27 2019, 22:40

Use pushKV

teamcity added a comment.May 27 2019, 22:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 27 2019, 22:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6025: Diff 8940.May 27 2019, 22:49
teamcity added a comment.May 27 2019, 22:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6026: Diff 8941.May 27 2019, 22:55
deadalnix added a child revision: D3138: [rpc] split wallet and non-wallet parts of DescribeAddressVisitor.May 28 2019, 00:49
markblundeberg accepted this revision.May 28 2019, 02:08
This revision is now accepted and ready to land.May 28 2019, 02:08
Closed by commit rABC0856db8ae051: Simplify "bool x = y ? true : false". Remove unused function and trailing… (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by deadalnix). · Explain WhyMay 28 2019, 11:26
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC0856db8ae051: Simplify "bool x = y ? true : false". Remove unused function and trailing….
deadalnix added a commit: rSTAGING0856db8ae051: Simplify "bool x = y ? true : false". Remove unused function and trailing….Sep 18 2019, 23:50

Revision Contents
Changeset List

PathSize
src/
2 lines
rpc/
4 lines
test/
6 lines
3 lines

Diff 8940

View Options

src/blockencodings.cpp

Loading...
View Options

src/rpc/misc.cpp

Loading...
View Options

src/test/miner_tests.cpp

Loading...
View Options

src/test/test_bitcoin.h

Loading...