Limit variable scope
Backport of Core PR10521
https://github.com/bitcoin/bitcoin/pull/10521
Details
Details
- Reviewers
jasonbcox deadalnix Fabien - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Project - Commits
- rSTAGING1b6adec5c141: Limit variable scope
rABC1b6adec5c141: Limit variable scope
make check test_runner.py ../configure --enable-debug make check
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| src/crypto/aes.cpp | ||
|---|---|---|
| 125 ↗ | (On Diff #8979) | uint8_t, just as it was before this patch |
| src/test/checkqueue_tests.cpp | ||
| 388 ↗ | (On Diff #8979) | please investigate why this does not match the original PR pre-patch. It's functionally the same, but the line ordering is not. |
| src/wallet/db.cpp | ||
| 494 ↗ | (On Diff #8979) | Missing backport here |
| src/wallet/wallet.cpp | ||
| 3688 ↗ | (On Diff #8979) | This neither matches the backport PR nor provides any value by scoping the entire function. Leave this change out. |
Comment Actions
Working on finding and backporting a dependency and will update this later.
| src/test/checkqueue_tests.cpp | ||
|---|---|---|
| 388 ↗ | (On Diff #8979) | Comparing https://reviews.bitcoinabc.org/D1771 with https://github.com/bitcoin/bitcoin/pull/9497/commits/96c7f2c3458950061b057fcd3daaf47b57e6bac7, and it looks like it was added that way. |
| src/wallet/db.cpp | ||
| 494 ↗ | (On Diff #8979) | Working on this one now. Will update this after the dependency is completed. |
| src/wallet/wallet.cpp | ||
| 3688 ↗ | (On Diff #8979) | Reverted. |
| src/test/checkqueue_tests.cpp | ||
|---|---|---|
| 388 ↗ | (On Diff #8979) | Ok. |
| src/wallet/db.cpp | ||
|---|---|---|
| 494 ↗ | (On Diff #8979) | Found the out of order backport: https://reviews.bitcoinabc.org/D2231 |
| src/wallet/db.cpp | ||
|---|---|---|
| 494 ↗ | (On Diff #8979) | Thank you. |