Page MenuHomePhabricator
Differential D3156

Also call other wallet notify callbacks in scheduler thread
ClosedPublic
Actions

Authored by deadalnix on May 30 2019, 01:16.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGb728870a8d8c: Also call other wallet notify callbacks in scheduler thread
rABCb728870a8d8c: Also call other wallet notify callbacks in scheduler thread
Summary

This runs Block{Connected,Disconnected}, SetBestChain, Inventory,
and TransactionAddedToMempool on the background scheduler thread.

Of those, only BlockConnected is used outside of Wallet/ZMQ, and
is used only for orphan transaction removal in net_processing,
something which does not need to be synchronous with anything
else.

This partially reverts #9583, re-enabling some of the gains from
#7946. This does not, however, re-enable the gains achieved by
repeatedly releasing cs_main between each transaction processed.

This is a partial backport of Core PR10286 : https://github.com/bitcoin/bitcoin/pull/10286/commits/e545dedf72bff2bd41c93c93eb576929fce37112

Depends on D3154

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
callschedulerthread
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6067
Build 10183: Bitcoin ABC Buildbot (legacy)
Build 10182: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 30 2019, 01:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 30 2019, 01:17
teamcity added a comment.May 30 2019, 01:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 30 2019, 01:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6067: Diff 9006.May 30 2019, 01:32
Fabien accepted this revision.May 30 2019, 12:37
This revision is now accepted and ready to land.May 30 2019, 12:37
markblundeberg added a subscriber: markblundeberg.May 30 2019, 16:45

@deadalnix I recall you mentioned a slight concern about this backport ... or was it just another commit in the same PR?

Closed by commit rABCb728870a8d8c: Also call other wallet notify callbacks in scheduler thread (authored by Matt Corallo <git@bluematt.me>, committed by deadalnix). · Explain WhyJun 1 2019, 14:25
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCb728870a8d8c: Also call other wallet notify callbacks in scheduler thread.
deadalnix added a commit: rSTAGINGb728870a8d8c: Also call other wallet notify callbacks in scheduler thread.Sep 18 2019, 23:56

Revision Contents
Changeset List

Diff 9006

View Options

src/validation.cpp

Loading...
View Options

src/validationinterface.h

Loading...
View Options

src/validationinterface.cpp

Loading...