There is no need to eval the start time -
just parse it as an integer.
Details
Details
- Reviewers
deadalnix sickpig awemany CCulianu - Group Reviewers
Restricted Project - Commits
- rSTAGING4a42c970a652: Parse UAHF start time as integer constant
rABC4a42c970a652: Parse UAHF start time as integer constant
../qa/pull-tester/rpc-tests.py
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| qa/rpc-tests/test_framework/cdefs.py | ||
|---|---|---|
| 31 ↗ | (On Diff #790) | This one as well. |
| qa/rpc-tests/test_framework/cdefs.py | ||
|---|---|---|
| 31 ↗ | (On Diff #790) | To do this one requires changing the C++ code to not use an expression, but a straight numeric constant. |
Comment Actions
@deadalnix : please confirm whether you really want the consensus.h code changed to turn DEFAULT_MAX_BLOCK_SIZE into a simple number instead of 8 * ONE_MEGABYTE .
Comment Actions
I accept as this is step forward, but I'd like to get rid of eval in there. There is no input validation and there could be any random crap that's evaled.