Page MenuHomePhabricator

[wallet] Tidy up CWallet::FundTransaction
ClosedPublic

Authored by nakihito on Jun 3 2019, 23:03.

Details

Reviewers
jasonbcox
deadalnix
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING951dc1f259ed: [wallet] Tidy up CWallet::FundTransaction
rABC951dc1f259ed: [wallet] Tidy up CWallet::FundTransaction
Summary

Ended up being just a typo correction because of the linter.

Part 1 of 2 of Core PR11864
https://github.com/bitcoin/bitcoin/pull/11864/commits/95d4450a41e9b3f7a739eeefec322bf9366ce824

Commit:

[wallet] Tidy up CWallet::FundTransaction 
95d4450a41e9b3f7a739eeefec322bf9366ce824
Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11864-1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6131
Build 10310: Bitcoin ABC Buildbot (legacy)
Build 10309: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Jun 3 2019, 23:03
jasonbcox requested changes to this revision.Jun 4 2019, 00:51

Please make the commit explicit in the summary. I know we can infer part 1 = the first commit, but not all backports are that simple. Best to get in the habit today.

This revision now requires changes to proceed.Jun 4 2019, 00:51
nakihito edited the summary of this revision. (Show Details)
nakihito edited the summary of this revision. (Show Details)

Please make the commit explicit in the summary. I know we can infer part 1 = the first commit, but not all backports are that simple. Best to get in the habit today.

Edited summary to better reflect which commit this diff refers to.

nakihito requested review of this revision.Jun 4 2019, 01:07
This revision is now accepted and ready to land.Jun 4 2019, 15:45