Merge #11864: Make CWallet::FundTransaction atomic
ClosedPublic
Actions

Authored by nakihito on Jun 4 2019, 17:14.

Details

Reviewers

jasonbcox
deadalnix
Fabien

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING48f9e5d014a1: Merge #11864: Make CWallet::FundTransaction atomic
rABC48f9e5d014a1: Merge #11864: Make CWallet::FundTransaction atomic

Summary

03a5dc9 [wallet] Make CWallet::FundTransaction atomic (João Barbosa)

Pull request description:

This PR fixes a race for `setLockedCoins` when `lockUnspents` is true. For instance, it should not be possible to use the same unspent in concurrent `fundrawtransaction` calls.

Now the `cs_main` and `cs_wallet` locks are held during `CreateTransaction` and `LockCoin`(s). Also added some style nits around the change.

Tree-SHA512: ccf383c0c5f6db775655a3e9ccd200c3bd831a83afae2b7c389564c74f7227f5bea86a4775727de2c3603b188f383f8a12d3f9d6d94f7887865c31c94ce95ef6

Part 2 of 2 of Core PR11864
https://github.com/bitcoin/bitcoin/pull/11864/commits/03a5dc9c3c522c500c77fdecd52d091db048d1b0

Commit:

Make CWallet::FundTransaction atomic
03a5dc9c3c522c500c77fdecd52d091db048d1b0

Depends on D3192

Test Plan

make check
test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR11864-2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6138
Build 10324: Bitcoin ABC Buildbot (legacy)
Build 10323: arc lint + arc unit

Event Timeline

nakihito created this revision.Jun 4 2019, 17:14

Owners added a reviewer: Restricted Owners Package.Jun 4 2019, 17:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 4 2019, 17:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6138: Diff 9122.Jun 4 2019, 17:29

jasonbcox accepted this revision.Jun 4 2019, 19:34

This revision is now accepted and ready to land.Jun 4 2019, 19:34

Closed by commit rABC48f9e5d014a1: Merge #11864: Make CWallet::FundTransaction atomic (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyJun 4 2019, 21:22

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABC48f9e5d014a1: Merge #11864: Make CWallet::FundTransaction atomic.

Nico Guiton <nico@bitframe.org> added a commit: rSTAGING48f9e5d014a1: Merge #11864: Make CWallet::FundTransaction atomic.Sep 19 2019, 00:01

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallet.cpp

5 lines

Diff 9122

View Options

Merge #11864: Make CWallet::FundTransaction atomicClosedPublicActions