Page MenuHomePhabricator

Merge #9890: Add a button to open the config file in a text editor
ClosedPublic

Authored by jasonbcox on Jun 5 2019, 18:52.

Details

Summary

9ab9e7d Add a button to open the config file in a text editor (Eric Shaw Jr)

Tree-SHA512: 1d13be9ac788a05a5116dbb3e1136ef65732dc2b5634547860612658109668922c9ea80b77bde4ba5beaa762d54f2a986a6064d4e34e963cdcd3d126a4eced37

Backport of Core PR9890
https://github.com/bitcoin/bitcoin/pull/9890/files

Test Plan
make check
bitcoin-qt
# Settings -> Options
# Click button to open configuration file
# See popup info window -> click OK
# Config file should open in the default editor

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Jun 5 2019, 18:52
Fabien requested changes to this revision.Jun 6 2019, 08:01
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/qt/guiutil.cpp
434 ↗(On Diff #9164)

boost::filesystem::path => fs::path

437 ↗(On Diff #9164)

Dito

This revision now requires changes to proceed.Jun 6 2019, 08:01
jasonbcox updated this revision to Diff 9213.Jun 6 2019, 21:14

Rebase + boost -> fs

deadalnix accepted this revision.Jun 6 2019, 22:39
jasonbcox added inline comments.Jun 6 2019, 23:10
src/qt/guiutil.cpp
434 ↗(On Diff #9164)

Cleaned up the includes at the top of this file as well: D3242

Fabien accepted this revision.Jun 7 2019, 09:09
This revision is now accepted and ready to land.Jun 7 2019, 09:09