Page MenuHomePhabricator
Differential D3233

Rework the wallet fees interface to make it closer to core's
ClosedPublic
Actions

Authored by deadalnix on Jun 6 2019, 13:58.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING75e6b44a4669: Rework the wallet fees interface to make it closer to core's
rABC75e6b44a4669: Rework the wallet fees interface to make it closer to core's
Summary

All of this was fubared for no good reason.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
walletfeerefactor
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6182
Build 10412: Bitcoin ABC Buildbot (legacy)
Build 10411: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 6 2019, 13:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 6 2019, 13:58
teamcity added a comment.Jun 6 2019, 13:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 6 2019, 14:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6182: Diff 9189.Jun 6 2019, 14:08
jasonbcox accepted this revision.Jun 6 2019, 18:43
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/qt/sendcoinsdialog.cpp
703

estimateSmartFee can be cleaned up after this as well. This can be done in a followup diff or as part of this one. Up to you.

This revision is now accepted and ready to land.Jun 6 2019, 18:43
Closed by commit rABC75e6b44a4669: Rework the wallet fees interface to make it closer to core's (authored by deadalnix). · Explain WhyJun 6 2019, 22:44
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC75e6b44a4669: Rework the wallet fees interface to make it closer to core's.
nakihito mentioned this in D3695: Merge #11133: Document assumptions that are beoing made to avoid division by zero.Jul 19 2019, 17:44
deadalnix added a commit: rSTAGING75e6b44a4669: Rework the wallet fees interface to make it closer to core's.Sep 19 2019, 00:07

Revision Contents
Changeset List

PathSize
src/
interfaces/
3 lines
7 lines
qt/
3 lines
18 lines
wallet/
13 lines
30 lines
4 lines

Diff 9189

View Options

src/interfaces/node.h

Loading...
View Options

src/interfaces/node.cpp

Loading...
View Options

src/qt/coincontroldialog.cpp

Loading...
View Options

src/qt/sendcoinsdialog.cpp

Loading...
View Options

src/wallet/fees.h

Loading...
View Options

src/wallet/fees.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...