Page MenuHomePhabricator

Merge #10500: Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings
ClosedPublic

Authored by nakihito on Thu, Jun 6, 21:46.

Details

Reviewers
jasonbcox
Fabien
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCff61577d2aea: Merge #10500: Avoid CWalletTx copies in GetAddressBalances and…
Summary

b9b814a38 Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings (Russell Yanofsky)

Tree-SHA512: 96a0612ca460ba1bfb3921f3aa348400fd3afa12c40f2ca1f3f04068b1574fe824d577e0123013d8898a4990084316dc1dfb541331849f0996ceff7f4eb25e6b

Backport of Core PR10500
https://github.com/bitcoin/bitcoin/pull/10500/

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Thu, Jun 6, 21:46
Owners added a reviewer: Restricted Owners Package.Thu, Jun 6, 21:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Jun 6, 21:46
nakihito added inline comments.Thu, Jun 6, 21:55
src/wallet/wallet.cpp
3729 ↗(On Diff #9215)

Here and line 3775 were changed from PAIRTYPE to std::pair here: https://reviews.bitcoinabc.org/D115

nakihito added inline comments.Thu, Jun 6, 21:58
src/wallet/wallet.cpp
3729 ↗(On Diff #9215)

This line was changed again from std::pair<uint256, CWalletTx> to the above here: https://reviews.bitcoinabc.org/D1696

jasonbcox accepted this revision.Thu, Jun 6, 22:40
This revision is now accepted and ready to land.Thu, Jun 6, 22:40