Page MenuHomePhabricator
Differential D3239

Merge #10500: Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings
ClosedPublic
Actions

Authored by nakihito on Jun 6 2019, 21:46.

Details

Reviewers
jasonbcox
Fabien
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGff61577d2aea: Merge #10500: Avoid CWalletTx copies in GetAddressBalances and…
rABCff61577d2aea: Merge #10500: Avoid CWalletTx copies in GetAddressBalances and…
Summary

b9b814a38 Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings (Russell Yanofsky)

Tree-SHA512: 96a0612ca460ba1bfb3921f3aa348400fd3afa12c40f2ca1f3f04068b1574fe824d577e0123013d8898a4990084316dc1dfb541331849f0996ceff7f4eb25e6b

Backport of Core PR10500
https://github.com/bitcoin/bitcoin/pull/10500/

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Jun 6 2019, 21:46
Owners added a reviewer: Restricted Owners Package.Jun 6 2019, 21:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 6 2019, 21:46
teamcity added a comment.Jun 6 2019, 21:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

nakihito added inline comments.Jun 6 2019, 21:55
src/wallet/wallet.cpp
3729 ↗(On Diff #9215)

Here and line 3775 were changed from PAIRTYPE to std::pair here: https://reviews.bitcoinabc.org/D115

teamcity added a comment.Jun 6 2019, 21:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6193: Diff 9215.Jun 6 2019, 21:57
nakihito added inline comments.Jun 6 2019, 21:58
src/wallet/wallet.cpp
3729 ↗(On Diff #9215)

This line was changed again from std::pair<uint256, CWalletTx> to the above here: https://reviews.bitcoinabc.org/D1696

jasonbcox accepted this revision.Jun 6 2019, 22:40
This revision is now accepted and ready to land.Jun 6 2019, 22:40
Closed by commit rABCff61577d2aea: Merge #10500: Avoid CWalletTx copies in GetAddressBalances and… (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by nakihito). · Explain WhyJun 6 2019, 23:05
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABCff61577d2aea: Merge #10500: Avoid CWalletTx copies in GetAddressBalances and….
nakihito mentioned this in D3525: Merge #13163: Make it clear which functions that are intended to be translation unit local (bitcoin-cli.cpp).Jul 2 2019, 18:24
nakihito mentioned this in D3526: Make printchunk() in support/lockedpool.cpp static.Jul 2 2019, 19:10
Nico Guiton <nico@bitframe.org> mentioned this in rABC7733c03f8c1f: Merge #13163: Make it clear which functions that are intended to be translation….Jul 2 2019, 20:37
Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGff61577d2aea: Merge #10500: Avoid CWalletTx copies in GetAddressBalances and….Sep 19 2019, 00:07
Nico Guiton <nico@bitframe.org> mentioned this in rSTAGING7733c03f8c1f: Merge #13163: Make it clear which functions that are intended to be translation….Sep 19 2019, 00:52

Revision Contents
Changeset List

PathSize
src/
wallet/
8 lines

Diff 9221

View Options

src/wallet/wallet.cpp

Loading...