Page MenuHomePhabricator

Merge #10560: Remove unused constants
ClosedPublic

Authored by nakihito on Fri, Jun 7, 19:52.

Details

Reviewers
jasonbcox
deadalnix
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC5b2a94af2a90: Merge #10560: Remove unused constants
Summary

dce8239 Comment out unused constant REJECT_DUST (practicalswift)
3289ef4 Remove unused constant MEMPOOL_GD_VERSION (practicalswift)

Tree-SHA512: 8dd772c963037cd0a1db0d5bf5f7a5cce3f5cd8fb6fa983949f9f0c1c8312ffd251a62c1e5d32f3584d2bcc562d8c8a9bf7900609dee9a4f12898caa2be9c38f

I actually went a head and deleted REJECT_DUST since it wasn't used anywhere and it made no sense to just leave it in even if it was uncommented.

Backport of Core PR10560
https://github.com/bitcoin/bitcoin/pull/10560/files

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Fri, Jun 7, 19:52
Owners added a reviewer: Restricted Owners Package.Fri, Jun 7, 19:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Jun 7, 19:52
deadalnix accepted this revision.Sat, Jun 8, 00:23
This revision is now accepted and ready to land.Sat, Jun 8, 00:23