Merge #10560: Remove unused constants
ClosedPublic
Actions

Authored by nakihito on Jun 7 2019, 19:52.

Details

Reviewers

jasonbcox
deadalnix
Fabien

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING5b2a94af2a90: Merge #10560: Remove unused constants
rABC5b2a94af2a90: Merge #10560: Remove unused constants

Summary

dce8239 Comment out unused constant REJECT_DUST (practicalswift)
3289ef4 Remove unused constant MEMPOOL_GD_VERSION (practicalswift)

Tree-SHA512: 8dd772c963037cd0a1db0d5bf5f7a5cce3f5cd8fb6fa983949f9f0c1c8312ffd251a62c1e5d32f3584d2bcc562d8c8a9bf7900609dee9a4f12898caa2be9c38f

I actually went a head and deleted REJECT_DUST since it wasn't used anywhere and it made no sense to just leave it in even if it was uncommented.

Backport of Core PR10560
https://github.com/bitcoin/bitcoin/pull/10560/files

Test Plan

make check
test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR10560

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6217
Build 10481: Bitcoin ABC Buildbot (legacy)
Build 10480: arc lint + arc unit

Event Timeline

nakihito created this revision.Jun 7 2019, 19:52

Owners added a reviewer: Restricted Owners Package.Jun 7 2019, 19:52

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 7 2019, 19:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6217: Diff 9250.Jun 7 2019, 20:02

deadalnix accepted this revision.Jun 8 2019, 00:23

This revision is now accepted and ready to land.Jun 8 2019, 00:23

Closed by commit rABC5b2a94af2a90: Merge #10560: Remove unused constants (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyJun 8 2019, 17:56

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABC5b2a94af2a90: Merge #10560: Remove unused constants.

Nico Guiton <nico@bitframe.org> added a commit: rSTAGING5b2a94af2a90: Merge #10560: Remove unused constants.Sep 19 2019, 00:09

Revision Contents
Changeset List

Path

Size

src/

consensus/

validation.h

1 line

version.h

3 lines

Diff 9250

View Options

src/consensus/validation.h