Page MenuHomePhabricator

[tests] Better stderr testing
ClosedPublic

Authored by Fabien on Jun 10 2019, 11:48.

Details

Summary
This PR tightens our checking of stderr and will cause tests to fail if
there is any unexpected message in stderr:

  - commit Write stdout/stderr to datadir instead of temp file writes
stderr to a file in the datadir instead of a temporary file. This helps
with debugging in the case of failure.
  - commit Use LIBC_FATAL_STDERR=1 in tests ensures that libc failures
are logged to stderr instead of the terminal.

Backport of core PR12755
https://github.com/bitcoin/bitcoin/pull/12755/files

Depends on D3273
Fixes T540

Test Plan
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12755
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6242
Build 10531: Bitcoin ABC Buildbot (legacy)
Build 10530: arc lint + arc unit