Page MenuHomePhabricator
Differential D3307

mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool::setSanityCheck(…)
ClosedPublic
Actions

Authored by deadalnix on Jun 12 2019, 21:12.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGaf600301e61b: mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool…
rABCaf600301e61b: mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool…
Summary

This is a backport of Core PR11689

Fix missing locking in CTxMemPool::check(const CCoinsViewCache *pcoins)

  • reading variable 'mapTx' requires holding mutex 'cs'
  • reading variable 'mapNextTx' requires holding mutex 'cs'
  • reading variable 'nCheckFrequency' requires holding mutex 'cs'

Fix missing locking in CTxMemPool::setSanityCheck(double dFrequency)

  • writing variable 'nCheckFrequency' requires holding mutex 'cs'

Add Clang thread safety analysis annotations

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr11689
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6307
Build 10661: Bitcoin ABC Buildbot (legacy)
Build 10660: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 12 2019, 21:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 12 2019, 21:12
teamcity added a comment.Jun 12 2019, 21:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 12 2019, 21:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6295: Diff 9367.Jun 12 2019, 21:21
Fabien added a subscriber: Fabien.Jun 13 2019, 10:44
Fabien added inline comments.
src/txmempool.h
575 ↗(On Diff #9367)

Please rebase on top of D3313

deadalnix updated this revision to Diff 9393.Jun 13 2019, 13:24

rebase

teamcity added a comment.Jun 13 2019, 13:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 13 2019, 13:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6307: Diff 9393.Jun 13 2019, 13:33
jasonbcox accepted this revision.Jun 14 2019, 00:43
This revision is now accepted and ready to land.Jun 14 2019, 00:43
deadalnix updated this revision to Diff 9443.Jun 14 2019, 15:07

rebase

teamcity added a comment.Jun 14 2019, 15:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 14 2019, 15:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6343: Diff 9443.Jun 14 2019, 15:18
Closed by commit rABCaf600301e61b: mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool… (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by deadalnix). · Explain WhyJun 14 2019, 15:53
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCaf600301e61b: mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool….
schancel mentioned this in D3351: Fix lock reference in miner.h.Jun 16 2019, 21:37
schancel mentioned this in rABC0965d7294845: Fix lock reference in miner.h.Jun 16 2019, 21:51
deadalnix added a commit: rSTAGINGaf600301e61b: mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool….Sep 19 2019, 00:19
schancel mentioned this in rSTAGING0965d7294845: Fix lock reference in miner.h.Sep 19 2019, 00:21

Revision Contents
Changeset List

PathSize
src/
9 lines
test/
5 lines
43 lines
2 lines

Diff 9393

View Options

src/miner.h

Loading...
View Options

src/test/mempool_tests.cpp

Loading...
View Options

src/txmempool.h

Loading...
View Options

src/txmempool.cpp

Loading...