Page MenuHomePhabricator

Merge #12652: bitcoin-cli: Provide a better error message when bitcoind is not running
ClosedPublic

Authored by nakihito on Jun 17 2019, 18:32.

Details

Summary

8b2ef27 tests: Test connecting with non-existing RPC cookie file (practicalswift)
a2b2476 tests: Test connecting to a non-existing server (practicalswift)
de04fde bitcoin-cli: Provide a better error message when bitcoind is not running (practicalswift)

Pull request description:

Provide a better `bitcoin-cli` error message when `bitcoind` is not running.

Before this patch:

```
$ killall -9 bitcoind
$ bitcoin-cli -testnet echo 'hello world'
error: Could not locate RPC credentials. No authentication cookie could be found, and RPC password is not set.  See -rpcpassword and -stdinrpcpass.  Configuration file: (/root/.bitcoin/bitcoin.conf)
```

After this patch:

```
$ killall -9 bitcoind
$ bitcoin-cli -testnet echo 'hello world'
error: Could not connect to the server 127.0.0.1:18332

Make sure the bitcoind server is running and that you are connecting to the correct RPC port.
```

Tree-SHA512: bb16e1a9a1ac110ee202c3cb99b5d7c5c1e5487a17e6cd101e12dc69e9525c14dc71f37b128c26ad615369a57547f15d0f1e29b207c1b2f2ee4b4ba7105f3433

Backport of Core PR12652
https://github.com/bitcoin/bitcoin/pull/12652

Test Plan
test_runner.py

./bitcoind
kill <bitcoind pid>
./bitcoin-cli <any rpc command>

This should output:
error: Could not connect to the server 127.0.0.1:18332

Make sure the bitcoind server is running and that you are connecting to the correct RPC port.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a reviewer: Restricted Owners Package.Jun 17 2019, 18:32
This revision is now accepted and ready to land.Jun 17 2019, 23:02