Page MenuHomePhabricator
Differential D336

De-Coreify doc/README_windows.txt
ClosedPublic
Actions

Authored by Mengerian on Jul 16 2017, 01:43.

Details

Reviewers
deadalnix
freetrader
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGb68b244b66b8: De-Coreify doc/README_windows.txt
rABCb68b244b66b8: De-Coreify doc/README_windows.txt
Test Plan

read it

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Mengerian created this revision.Jul 16 2017, 01:43
Owners added a reviewer: Restricted Owners Package.Jul 16 2017, 01:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 16 2017, 01:43
freetrader requested changes to this revision.EditedJul 16 2017, 10:38

This file is referenced in several build / packaging files.
We cannot simply remove it without making sure whatever depends on it still works without it.

e.g. Makefile.am , share/setup.nsi.in

We need to understand its function first - is it displayed (maybe optionally) during execution of the Windows installer ...

This revision now requires changes to proceed.Jul 16 2017, 10:38
Mengerian updated this revision to Diff 838.Jul 16 2017, 17:45
Mengerian edited edge metadata.
Mengerian retitled this revision from remove doc/README_windows.txt This document has no information specific to Windows, and only repeated information from doc/README.md to remove doc/README_windows.txt.
Mengerian edited the summary of this revision. (Show Details)

Do not remove doc/README_windows.txt, instead just De-Coreify it

Based on freetrader review

Mengerian retitled this revision from remove doc/README_windows.txt to DE-Coreify doc/README_windows.txt.Jul 16 2017, 17:48
Mengerian edited the summary of this revision. (Show Details)
Mengerian retitled this revision from DE-Coreify doc/README_windows.txt to De-Coreify doc/README_windows.txt.
freetrader accepted this revision.Jul 16 2017, 20:57

Changes look good to me - no objections to making it version-independent at least in the beginning.

This revision is now accepted and ready to land.Jul 16 2017, 20:57
Mengerian added a comment.Jul 16 2017, 22:50
In D336#5669, @freetrader wrote:

Changes look good to me - no objections to making it version-independent at least in the beginning.

Yeah, I figured version independent is better, one less place to remember incrementing versions with each release is better

Closed by commit rABCb68b244b66b8: De-Coreify doc/README_windows.txt (authored by Mengerian, committed by Mengerian). · Explain WhyJul 16 2017, 22:51
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
doc/
47 lines

Diff 839

View Options

doc/README_windows.txt

Loading...