Page MenuHomePhabricator
Differential D3394

wallet: Switch to using output groups instead of coins in coin selection
ClosedPublic
Actions

Authored by deadalnix on Jun 22 2019, 21:47.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGafa4430b94b9: wallet: Switch to using output groups instead of coins in coin selection
rABCafa4430b94b9: wallet: Switch to using output groups instead of coins in coin selection
Summary

This is a partial backport of Core PR12257 : https://github.com/bitcoin/bitcoin/pull/12257/commits/59d6f7b4e2f847ec1f2ff46c84e6157655984f85

Depends on D3377, D3389, D3392, D3387 and D3393

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
switchtooutputgroup
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6475
Build 10997: Bitcoin ABC Buildbot (legacy)
Build 10996: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 22 2019, 21:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 22 2019, 21:47
teamcity added a comment.Jun 22 2019, 21:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix edited the summary of this revision. (Show Details)Jun 22 2019, 21:48
deadalnix removed a parent revision: D3378: Actually disable BnB when there are preset inputs.
deadalnix added a child revision: D3395: test: Add basic testing for wallet groups.Jun 22 2019, 21:53
teamcity added a comment.Jun 22 2019, 21:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6450: Diff 9597.Jun 22 2019, 21:55
deadalnix added a child revision: D3396: wallet: Remove deprecated OutputEligibleForSpending.Jun 22 2019, 21:56
deadalnix added a child revision: D3397: clean-up: Remove no longer used ivars from CInputCoin.Jun 22 2019, 22:00
deadalnix added a child revision: D3398: doc: Add release notes for -avoidpartialspends.Jun 22 2019, 22:03
Fabien requested changes to this revision.Jun 24 2019, 12:04
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/coinselection.cpp
312 ↗(On Diff #9597)

size_t

320 ↗(On Diff #9597)

I think it makes sense to keep these inline with the LogPrintf as it is more like an annotation rather than a comment.

src/wallet/coinselection.h
112 ↗(On Diff #9597)

vCoins => groups

src/wallet/test/coinselector_tests.cpp
127 ↗(On Diff #9597)

above => below

624 ↗(On Diff #9597)

Why ?

src/wallet/wallet.cpp
2772 ↗(On Diff #9597)

Revert

2773 ↗(On Diff #9597)

Dito

This revision now requires changes to proceed.Jun 24 2019, 12:04
deadalnix added inline comments.Jun 25 2019, 14:27
src/wallet/coinselection.cpp
320 ↗(On Diff #9597)

We don't do comment on the same line, if fucks up blame and formatting.

deadalnix updated this revision to Diff 9646.Jun 25 2019, 14:30

Rebase and address comments

teamcity added a comment.Jun 25 2019, 14:30

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 25 2019, 14:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6475: Diff 9646.Jun 25 2019, 14:37
Fabien accepted this revision.Jun 25 2019, 14:42
This revision is now accepted and ready to land.Jun 25 2019, 14:42
Closed by commit rABCafa4430b94b9: wallet: Switch to using output groups instead of coins in coin selection (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>, committed by deadalnix). · Explain WhyJun 25 2019, 14:58
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCafa4430b94b9: wallet: Switch to using output groups instead of coins in coin selection.
deadalnix added a commit: rSTAGINGafa4430b94b9: wallet: Switch to using output groups instead of coins in coin selection.Sep 19 2019, 00:31

Revision Contents
Changeset List

PathSize
src/
bench/
41 lines
wallet/
4 lines
94 lines
test/
243 lines
2 lines
94 lines

Diff 9646

View Options

src/bench/coin_selection.cpp

Loading...
View Options

src/wallet/coinselection.h

Loading...
View Options

src/wallet/coinselection.cpp

Loading...
View Options

src/wallet/test/coinselector_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...