Page MenuHomePhabricator

wallet: Switch to using output groups instead of coins in coin selection
ClosedPublic

Authored by deadalnix on Jun 22 2019, 21:47.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
switchtooutputgroup
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6475
Build 10997: Bitcoin ABC Buildbot (legacy)
Build 10996: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Jun 24 2019, 12:04
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/coinselection.cpp
312 ↗(On Diff #9597)

size_t

320 ↗(On Diff #9597)

I think it makes sense to keep these inline with the LogPrintf as it is more like an annotation rather than a comment.

src/wallet/coinselection.h
112 ↗(On Diff #9597)

vCoins => groups

src/wallet/test/coinselector_tests.cpp
127 ↗(On Diff #9597)

above => below

624 ↗(On Diff #9597)

Why ?

src/wallet/wallet.cpp
2772 ↗(On Diff #9597)

Revert

2773 ↗(On Diff #9597)

Dito

This revision now requires changes to proceed.Jun 24 2019, 12:04
src/wallet/coinselection.cpp
320 ↗(On Diff #9597)

We don't do comment on the same line, if fucks up blame and formatting.

Rebase and address comments

This revision is now accepted and ready to land.Jun 25 2019, 14:42