Page MenuHomePhabricator

[ibd.sh] Store datadir and debug.log paths in variables
ClosedPublic

Authored by jasonbcox on Jun 28 2019, 00:18.

Details

Summary

This makes it easy to change the location of the datadir or debug.log without updating it in a bunch of places and risking
the chance of forgetting or typos.

Test Plan

IBD on TeamCity via D3453

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Jun 28 2019, 00:18
jasonbcox planned changes to this revision.Jun 28 2019, 00:19
jasonbcox edited the test plan for this revision. (Show Details)Jun 28 2019, 00:23
jasonbcox updated this revision to Diff 9773.Jun 28 2019, 16:04

Added DATA_DIR

jasonbcox planned changes to this revision.Jun 28 2019, 16:04
jasonbcox retitled this revision from [ibd.sh] Store debug.log location in a variable to [ibd.sh] Store datadir and debug.log paths in variables.Jun 28 2019, 16:05
jasonbcox edited the summary of this revision. (Show Details)
jasonbcox requested review of this revision.Jun 29 2019, 15:30
deadalnix requested changes to this revision.Jun 30 2019, 00:45
deadalnix added inline comments.
contrib/teamcity/ibd.sh
22 ↗(On Diff #9773)

Try that with a space in DATA_DIR

This revision now requires changes to proceed.Jun 30 2019, 00:45
jasonbcox updated this revision to Diff 9885.Jul 1 2019, 21:35

Fixed bug when datadir contains whitespace

Fabien accepted this revision.Jul 2 2019, 06:15
deadalnix accepted this revision.Jul 3 2019, 18:30
This revision is now accepted and ready to land.Jul 3 2019, 18:30
This revision was automatically updated to reflect the committed changes.