Page MenuHomePhabricator

[ibd.sh] Store datadir and debug.log paths in variables
ClosedPublic

Authored by jasonbcox on Jun 28 2019, 00:18.

Details

Summary

This makes it easy to change the location of the datadir or debug.log without updating it in a bunch of places and risking
the chance of forgetting or typos.

Test Plan

IBD on TeamCity via D3453

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ibd-debug-log
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6539
Build 11125: Bitcoin ABC Buildbot (legacy)
Build 11124: arc lint + arc unit

Event Timeline

jasonbcox retitled this revision from [ibd.sh] Store debug.log location in a variable to [ibd.sh] Store datadir and debug.log paths in variables.Jun 28 2019, 16:05
jasonbcox edited the summary of this revision. (Show Details)
deadalnix requested changes to this revision.Jun 30 2019, 00:45
deadalnix added inline comments.
contrib/teamcity/ibd.sh
22

Try that with a space in DATA_DIR

This revision now requires changes to proceed.Jun 30 2019, 00:45

Fixed bug when datadir contains whitespace

This revision is now accepted and ready to land.Jul 3 2019, 18:30