Page MenuHomePhabricator
Differential D3489

Merge #14554: qt: Remove unused `adjustedTime` parameter
ClosedPublic
Actions

Authored by markblundeberg on Jun 30 2019, 23:44.

Details

Reviewers
deadalnix
jasonbcox
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING8a5dd4971291: Merge #14554: qt: Remove unused `adjustedTime` parameter
rABC8a5dd4971291: Merge #14554: qt: Remove unused `adjustedTime` parameter
Summary

PR14554 backport https://github.com/bitcoin/bitcoin/pull/14554/files
04972fefd12c2c764b5f2afee87228e8d90f2448 Remove unused adjustedTime parameter (Hennadii Stepanov)

Pull request description:

After merging #13622 the `adjustedTime` parameter in the `updateStatus` function is unused.

Depends on D3477

Test Plan

make with qt support enabled.
test_bitcoin_qt

Diff Detail

Repository
rABC Bitcoin ABC
Branch
patch
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6574
Build 11195: Bitcoin ABC Buildbot (legacy)
Build 11194: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jun 30 2019, 23:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 30 2019, 23:45
teamcity added a comment.Jun 30 2019, 23:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 30 2019, 23:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6574: Diff 9827.Jun 30 2019, 23:56
markblundeberg added a child revision: D3491: Merge #14556: qt: fix confirmed transaction labeled "open".Jul 1 2019, 00:34
Fabien accepted this revision.Jul 1 2019, 09:11
This revision is now accepted and ready to land.Jul 1 2019, 09:11
Closed by commit rABC8a5dd4971291: Merge #14554: qt: Remove unused `adjustedTime` parameter (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJul 1 2019, 17:48
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABC8a5dd4971291: Merge #14554: qt: Remove unused `adjustedTime` parameter.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING8a5dd4971291: Merge #14554: qt: Remove unused `adjustedTime` parameter.Sep 19 2019, 00:48

Revision Contents
Changeset List

Diff 9827

View Options

src/interfaces/wallet.h

Loading...
View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/qt/transactiondesc.h

Loading...
View Options

src/qt/transactiondesc.cpp

Loading...
View Options

src/qt/transactionrecord.h

Loading...
View Options

src/qt/transactionrecord.cpp

Loading...
View Options

src/qt/transactiontablemodel.cpp

Loading...