Page MenuHomePhabricator
Differential D349

Update AccessCoins API to use the Coin abstraction
ClosedPublic
Actions

Authored by deadalnix on Jul 20 2017, 02:14.

Details

Reviewers
freetrader
kyuupichan
Group Reviewers
Restricted Project
Commits
rSTAGINGf701ed902693: Update AccessCoins API to use the Coin abstraction
rABCf701ed902693: Update AccessCoins API to use the Coin abstraction
Summary

This is a continuation of the work started in D342 . Before changing the underlying storage, we need to miigrate the API.

Test Plan
make check
../qa/pull-tester/rpc-tests.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jul 20 2017, 02:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 20 2017, 02:14
freetrader accepted this revision.Jul 20 2017, 13:11

Didn't notice any defects in review.
Regression tests were ok, save for a couple of tests which fail intermittently, but those failures seem unrelated to the change at hand.

This revision is now accepted and ready to land.Jul 20 2017, 13:11
Closed by commit rABCf701ed902693: Update AccessCoins API to use the Coin abstraction (authored by deadalnix, committed by deadalnix). · Explain WhyJul 20 2017, 13:24
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
10 lines
23 lines
29 lines
rpc/
22 lines
test/
137 lines
8 lines
17 lines
19 lines
13 lines
88 lines

Diff 881

View Options

src/bitcoin-tx.cpp

Loading...
View Options

src/coins.h

Loading...
View Options

src/coins.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/test/coins_tests.cpp

Loading...
View Options

src/test/script_P2SH_tests.cpp

Loading...
View Options

src/test/undo_tests.cpp

Loading...
View Options

src/txmempool.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...