docs: Add a note about the source code filename naming convention
ClosedPublic
Actions

Authored by deadalnix on Jul 6 2019, 14:27.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING0ecd638de300: docs: Add a note about the source code filename naming convention
rABC0ecd638de300: docs: Add a note about the source code filename naming convention

Summary

Do not use uppercase characters in source code filenames

This is a backport of Core PR13312

Test Plan

make check
ninja all check-all bench-bitcoin

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jul 6 2019, 14:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 6 2019, 14:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6696: Diff 10033.Jul 6 2019, 14:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

This deserves a linter.

This revision is now accepted and ready to land.Jul 6 2019, 14:37

Closed by commit rABC0ecd638de300: docs: Add a note about the source code filename naming convention (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by deadalnix). · Explain WhyJul 6 2019, 15:05

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC0ecd638de300: docs: Add a note about the source code filename naming convention.

Fabien mentioned this in D3593: [LINTER] Enforce source code file name conventions.Jul 8 2019, 12:44

Fabien mentioned this in rABC335a7e5c65d6: [LINTER] Enforce source code file name conventions.Jul 8 2019, 19:36

deadalnix added a commit: rSTAGING0ecd638de300: docs: Add a note about the source code filename naming convention.Sep 19 2019, 00:59

Fabien mentioned this in rSTAGING335a7e5c65d6: [LINTER] Enforce source code file name conventions.Sep 19 2019, 01:05

Revision Contents
Changeset List

Path

Size

doc/

developer-notes.md

6 lines

src/

Makefile.bench.include

2 lines

Makefile.test.include

4 lines

bench/

CMakeLists.txt

2 lines

Examples.cpp

	examples.cpp
	Examples.cpp

net_processing.cpp

2 lines

test/

CMakeLists.txt

4 lines

DoS_tests.cpp

	denialofservice_tests.cpp
	DoS_tests.cpp

2 lines

script_P2SH_tests.cpp

	script_p2sh_tests.cpp
	script_P2SH_tests.cpp

2 lines

Diff 10034

View Options

doc/developer-notes.md

View Options

src/Makefile.bench.include

View Options

src/Makefile.test.include

View Options

src/bench/CMakeLists.txt

View Options

src/bench/Examples.cpp

View Options

src/bench/examples.cpp

View Options

src/net_processing.cpp

View Options

src/test/CMakeLists.txt

View Options

src/test/DoS_tests.cpp

View Options

src/test/denialofservice_tests.cpp

View Options

src/test/script_P2SH_tests.cpp

View Options

src/test/script_p2sh_tests.cpp

docs: Add a note about the source code filename naming conventionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 10034

doc/developer-notes.md

src/Makefile.bench.include

src/Makefile.test.include

src/bench/CMakeLists.txt

src/bench/Examples.cpp

src/bench/examples.cpp

src/net_processing.cpp

src/test/CMakeLists.txt

src/test/DoS_tests.cpp

src/test/denialofservice_tests.cpp

src/test/script_P2SH_tests.cpp

src/test/script_p2sh_tests.cpp

docs: Add a note about the source code filename naming convention
ClosedPublic
Actions

Revision Contents
Changeset List