Page MenuHomePhabricator
Differential D3573

Remove test for legacy address when parsing URL in the GUI
ClosedPublic
Actions

Authored by deadalnix on Jul 7 2019, 00:25.

Details

Reviewers
markblundeberg
Group Reviewers
Restricted Project
Commits
rSTAGING841945f0b308: Remove test for legacy address when parsing URL in the GUI
rABC841945f0b308: Remove test for legacy address when parsing URL in the GUI
Summary

As per title. This is further cleaning up the GUI from legacy addresses.

Test Plan

Open bitcoin-qt.

Click file -> open URI -> paste a legacy URI.

Ensure that the URL is rejected.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
IsCashAddrEncoded
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6701
Build 11449: Bitcoin ABC Buildbot (legacy)
Build 11448: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 7 2019, 00:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 7 2019, 00:25
teamcity added a comment.Jul 7 2019, 00:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix updated this revision to Diff 10043.Jul 7 2019, 00:30

Remove unecessary header include

teamcity added a comment.Jul 7 2019, 00:30

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 7 2019, 00:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6700: Diff 10042.Jul 7 2019, 00:33
teamcity added a comment.Jul 7 2019, 00:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6701: Diff 10043.Jul 7 2019, 00:37
deadalnix added a child revision: D3577: Split key_io (address/key encodings) off from base58.Jul 7 2019, 14:38
markblundeberg accepted this revision.Jul 8 2019, 00:15
This revision is now accepted and ready to land.Jul 8 2019, 00:15
Closed by commit rABC841945f0b308: Remove test for legacy address when parsing URL in the GUI (authored by deadalnix). · Explain WhyJul 8 2019, 00:34
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC841945f0b308: Remove test for legacy address when parsing URL in the GUI.
deadalnix added a commit: rSTAGING841945f0b308: Remove test for legacy address when parsing URL in the GUI.Sep 19 2019, 01:01

Revision Contents
Changeset List

PathSize
src/
qt/
15 lines
test/
1 line
75 lines

Diff 10043

View Options

src/qt/guiutil.cpp

Loading...
View Options

src/qt/test/uritests.h

Loading...
View Options

src/qt/test/uritests.cpp

Loading...