Page MenuHomePhabricator

Split off key_io_tests from base58_tests
ClosedPublic

Authored by deadalnix on Sun, Jul 7, 14:46.

Details

Reviewers
markblundeberg
Group Reviewers
Restricted Project
Commits
rABCaceb19bb7114: Split off key_io_tests from base58_tests
Summary
Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Sun, Jul 7, 14:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptSun, Jul 7, 14:46
markblundeberg requested changes to this revision.Mon, Jul 8, 01:16
markblundeberg added a subscriber: markblundeberg.
markblundeberg added inline comments.
src/test/key_io_tests.cpp
48 ↗(On Diff #10051)

Can you find which backport did we miss for this case flipping thing?

This revision now requires changes to proceed.Mon, Jul 8, 01:16
deadalnix added inline comments.Mon, Jul 8, 12:54
src/test/key_io_tests.cpp
48 ↗(On Diff #10051)

Good catch.

deadalnix updated this revision to Diff 10089.Mon, Jul 8, 14:08

Rebase on top of D3594

markblundeberg accepted this revision.Mon, Jul 8, 14:12
This revision is now accepted and ready to land.Mon, Jul 8, 14:12
This revision was automatically updated to reflect the committed changes.