Page MenuHomePhabricator
Differential D3578

Split off key_io_tests from base58_tests
ClosedPublic
Actions

Authored by deadalnix on Jul 7 2019, 14:46.

Details

Reviewers
markblundeberg
Group Reviewers
Restricted Project
Commits
rSTAGINGaceb19bb7114: Split off key_io_tests from base58_tests
rABCaceb19bb7114: Split off key_io_tests from base58_tests
Summary

This is a partial backport of Core PR11372 : https://github.com/bitcoin/bitcoin/pull/11372/commits/92f1f8b3197c2ba3cf65556070509838098975a4

Depends on D3577

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr11372
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6706
Build 11459: Bitcoin ABC Buildbot (legacy)
Build 11458: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 7 2019, 14:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 7 2019, 14:46
teamcity added a comment.Jul 7 2019, 14:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 7 2019, 14:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6706: Diff 10051.Jul 7 2019, 14:53
markblundeberg requested changes to this revision.Jul 8 2019, 01:16
markblundeberg added a subscriber: markblundeberg.
markblundeberg added inline comments.
src/test/key_io_tests.cpp
48

Can you find which backport did we miss for this case flipping thing?

This revision now requires changes to proceed.Jul 8 2019, 01:16
deadalnix added inline comments.Jul 8 2019, 12:54
src/test/key_io_tests.cpp
48

Good catch.

deadalnix mentioned this in D3594: Partial backport of Core PR11167 to have similar feature in base58_tests.cpp.Jul 8 2019, 14:00
deadalnix updated this revision to Diff 10089.Jul 8 2019, 14:08

Rebase on top of D3594

teamcity added a comment.Jul 8 2019, 14:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg accepted this revision.Jul 8 2019, 14:12
This revision is now accepted and ready to land.Jul 8 2019, 14:12
teamcity added a comment.Jul 8 2019, 14:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6733: Diff 10089.Jul 8 2019, 14:14
deadalnix mentioned this in rABCef3a4e71ac11: Partial backport of Core PR11167 to have similar feature in base58_tests.cpp.Jul 8 2019, 15:51
Closed by commit rABCaceb19bb7114: Split off key_io_tests from base58_tests (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyJul 8 2019, 17:19
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCaceb19bb7114: Split off key_io_tests from base58_tests.
deadalnix mentioned this in rSTAGINGef3a4e71ac11: Partial backport of Core PR11167 to have similar feature in base58_tests.cpp.Sep 19 2019, 01:03
deadalnix added a commit: rSTAGINGaceb19bb7114: Split off key_io_tests from base58_tests.

Revision Contents
Changeset List

PathSize
src/
11 lines
test/
9 lines
142 lines
data/
key_io_invalid.json
base58_keys_invalid.json
152 lines
key_io_valid.json
base58_keys_valid.json
461 lines
key_io_tests.cpp
base58_tests.cpp
124 lines

Diff 10051

View Options

src/Makefile.test.include

Loading...
View Options

src/test/CMakeLists.txt

Loading...
View Options

src/test/base58_tests.cpp

Loading...
View Options

src/test/data/base58_keys_invalid.json

Loading...
View Options

src/test/data/base58_keys_valid.json

Loading...
View Options

src/test/data/key_io_invalid.json

Loading...
View Options

src/test/data/key_io_valid.json

Loading...
View Options

src/test/key_io_tests.cpp

Loading...