Page MenuHomePhabricator

Replace CBitcoinSecret with {Encode,Decode}Secret
ClosedPublic

Authored by deadalnix on Sun, Jul 7, 14:29.

Details

Reviewers
markblundeberg
Group Reviewers
Restricted Project
Commits
rABCb56057837ced: Replace CBitcoinSecret with {Encode,Decode}Secret
Summary
Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Sun, Jul 7, 14:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptSun, Jul 7, 14:29
markblundeberg requested changes to this revision.Mon, Jul 8, 00:53
markblundeberg added a subscriber: markblundeberg.
markblundeberg added inline comments.
src/base58.cpp
267 ↗(On Diff #10048)

unsigned char -> uint8_t needed in a few places, this is the first.

This revision now requires changes to proceed.Mon, Jul 8, 00:53
markblundeberg accepted this revision.Mon, Jul 8, 01:57
markblundeberg added inline comments.
src/base58.cpp
267 ↗(On Diff #10048)

Eh I see it's fixed in the follow up, doesn't really matter then.

This revision is now accepted and ready to land.Mon, Jul 8, 01:57