Page MenuHomePhabricator
Differential D3575

Replace CBitcoinSecret with {Encode,Decode}Secret
ClosedPublic
Actions

Authored by deadalnix on Jul 7 2019, 14:29.

Details

Reviewers
markblundeberg
Group Reviewers
Restricted Project
Commits
rSTAGINGb56057837ced: Replace CBitcoinSecret with {Encode,Decode}Secret
rABCb56057837ced: Replace CBitcoinSecret with {Encode,Decode}Secret
Summary

This is a partial backpor of Core PR11372 : https://github.com/bitcoin/bitcoin/pull/11372/commits/32e69fa0df8fc1cfc8ac4f8381bc54b8f33e1c38

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
bitcoinsecret
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6703
Build 11453: Bitcoin ABC Buildbot (legacy)
Build 11452: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 7 2019, 14:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 7 2019, 14:29
teamcity added a comment.Jul 7 2019, 14:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix added a child revision: D3576: Stop using CBase58Data for ext keys.Jul 7 2019, 14:34
teamcity added a comment.Jul 7 2019, 14:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6703: Diff 10048.Jul 7 2019, 14:36
markblundeberg requested changes to this revision.Jul 8 2019, 00:53
markblundeberg added a subscriber: markblundeberg.
markblundeberg added inline comments.
src/base58.cpp
267

unsigned char -> uint8_t needed in a few places, this is the first.

This revision now requires changes to proceed.Jul 8 2019, 00:53
markblundeberg accepted this revision.Jul 8 2019, 01:57
markblundeberg added inline comments.
src/base58.cpp
267

Eh I see it's fixed in the follow up, doesn't really matter then.

This revision is now accepted and ready to land.Jul 8 2019, 01:57
Closed by commit rABCb56057837ced: Replace CBitcoinSecret with {Encode,Decode}Secret (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyJul 8 2019, 12:12
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCb56057837ced: Replace CBitcoinSecret with {Encode,Decode}Secret.
deadalnix added a commit: rSTAGINGb56057837ced: Replace CBitcoinSecret with {Encode,Decode}Secret.Sep 19 2019, 01:02

Revision Contents
Changeset List

PathSize
src/
16 lines
53 lines
7 lines
rpc/
10 lines
9 lines
test/
22 lines
5 lines
25 lines
8 lines
wallet/
45 lines

Diff 10048

View Options

src/base58.h

Loading...
View Options

src/base58.cpp

Loading...
View Options

src/bitcoin-tx.cpp

Loading...
View Options

src/rpc/misc.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/test/base58_tests.cpp

Loading...
View Options

src/test/bloom_tests.cpp

Loading...
View Options

src/test/key_tests.cpp

Loading...
View Options

src/test/sigcache_tests.cpp

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...