Differential D3576

Stop using CBase58Data for ext keys
ClosedPublic
Actions

Authored by deadalnix on Jul 7 2019, 14:34.

Details

Reviewers

markblundeberg

Group Reviewers

Restricted Project

Commits

rSTAGINGe61a3659d2b3: Stop using CBase58Data for ext keys
rABCe61a3659d2b3: Stop using CBase58Data for ext keys

Summary

This is a partial backport of Core PR11372 : https://github.com/bitcoin/bitcoin/pull/11372/commits/ebfe217b15d21656a173e5c102f826d17c6c8be4

Depends on D3575

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

killCBase58Data

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6704
Build 11455: Bitcoin ABC Buildbot (legacy)
Build 11454: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 7 2019, 14:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 7 2019, 14:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix added a child revision: D3577: Split key_io (address/key encodings) off from base58.Jul 7 2019, 14:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6704: Diff 10049.Jul 7 2019, 14:45

markblundeberg accepted this revision.Jul 8 2019, 00:56

This revision is now accepted and ready to land.Jul 8 2019, 00:56

Closed by commit rABCe61a3659d2b3: Stop using CBase58Data for ext keys (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyJul 8 2019, 12:24

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCe61a3659d2b3: Stop using CBase58Data for ext keys.

deadalnix added a commit: rSTAGINGe61a3659d2b3: Stop using CBase58Data for ext keys.Sep 19 2019, 01:02

Revision Contents
Changeset List

Path

Size

src/

base58.h

76 lines

base58.cpp

110 lines

test/

bip32_tests.cpp

22 lines

wallet/

rpcdump.cpp

5 lines

Diff 10049

View Options

src/base58.h

View Options

src/base58.cpp

View Options

src/test/bip32_tests.cpp

View Options

Stop using CBase58Data for ext keysClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 10049

src/base58.h

src/base58.cpp

src/test/bip32_tests.cpp

src/wallet/rpcdump.cpp

Stop using CBase58Data for ext keys
ClosedPublic
Actions

Revision Contents
Changeset List