Page MenuHomePhabricator
Differential D3590

whitespaces nits in CMakeLists
ClosedPublic
Actions

Authored by markblundeberg on Jul 8 2019, 01:40.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGf6e0b012cc45: whitespaces nits in CMakeLists
rABCf6e0b012cc45: whitespaces nits in CMakeLists
Summary

This has been bugging me every time I update these files. My editor
automatically strips trailing whitespace throughout the file, and appends
a trailing newline. I've gone through all the CMakeLists and found all
the nits.

Test Plan

run cmake

Diff Detail

Repository
rABC Bitcoin ABC
Branch
remspace
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6725
Build 11497: Bitcoin ABC Buildbot (legacy)
Build 11496: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jul 8 2019, 01:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 8 2019, 01:40
teamcity added a comment.Jul 8 2019, 01:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg updated this revision to Diff 10072.Jul 8 2019, 01:45
markblundeberg retitled this revision from remove empty line indentation from CMakeLists to whitespaces nits in CMakeLists.
markblundeberg edited the summary of this revision. (Show Details)

did all the CMakeLists, not just the main one

teamcity added a comment.Jul 8 2019, 01:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 8 2019, 01:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6725: Diff 10071.Jul 8 2019, 01:48
teamcity added a comment.Jul 8 2019, 01:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6726: Diff 10072.Jul 8 2019, 01:51
markblundeberg added a comment.Jul 8 2019, 01:55

I am not actually able to run CMake in my local setup ... if someone else can verify this before accepting that would be great.

Fabien accepted this revision.Jul 8 2019, 10:23

I have no cmake build failure, with or without this patch.

This revision is now accepted and ready to land.Jul 8 2019, 10:23
Closed by commit rABCf6e0b012cc45: whitespaces nits in CMakeLists (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJul 8 2019, 13:55
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABCf6e0b012cc45: whitespaces nits in CMakeLists.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGINGf6e0b012cc45: whitespaces nits in CMakeLists.Sep 19 2019, 01:02

Revision Contents
Changeset List

PathSize
src/
10 lines

Diff 10071

View Options

src/CMakeLists.txt

Loading...