Page MenuHomePhabricator
Differential D3593

[LINTER] Enforce source code file name conventions
ClosedPublic
Actions

Authored by Fabien on Jul 8 2019, 12:44.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING335a7e5c65d6: [LINTER] Enforce source code file name conventions
rABC335a7e5c65d6: [LINTER] Enforce source code file name conventions
Summary

Follow-up for D3572.

This linter ensures the source file names are compliant with the naming
conventions from the developer notes.

Test Plan
arc lint --everything # No error

Rename src/addrdb.cpp to src/addrDb.cpp

arc lint -- src/addrDb.cpp

Check the error is catched by the linter.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
linter_filename_convention
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6740
Build 11527: Bitcoin ABC Buildbot (legacy)
Build 11526: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 8 2019, 12:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 8 2019, 12:44
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jul 8 2019, 12:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 8 2019, 12:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6730: Diff 10082.Jul 8 2019, 12:50
deadalnix accepted this revision.Jul 8 2019, 17:17
This revision is now accepted and ready to land.Jul 8 2019, 17:17
Fabien updated this revision to Diff 10106.Jul 8 2019, 19:16

Rebase

teamcity added a comment.Jul 8 2019, 19:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 8 2019, 19:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6740: Diff 10106.Jul 8 2019, 19:22
Closed by commit rABC335a7e5c65d6: [LINTER] Enforce source code file name conventions (authored by Fabien). · Explain WhyJul 8 2019, 19:36
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC335a7e5c65d6: [LINTER] Enforce source code file name conventions.
Fabien mentioned this in D3983: Add linter: Enforce the source code file naming convention described in the developer notes.Sep 3 2019, 07:46
Fabien added a commit: rSTAGING335a7e5c65d6: [LINTER] Enforce source code file name conventions.Sep 19 2019, 01:04

Revision Contents
Changeset List

Diff 10106

View Options

.arclint

Loading...
View Options

arcanist/.phutil_module_cache

Loading...
View Options

arcanist/__phutil_library_map__.php

Loading...
View Options

arcanist/linter/FileNameLinter.php

Loading...