Page MenuHomePhabricator

[wallet] Fix potential memory leak in CreateWalletFromFile
ClosedPublic

Authored by Fabien on Wed, Jul 10, 08:55.

Details

Summary
Fix proposed by ryanofsky in
https://github.com/bitcoin/bitcoin/pull/12647#discussion_r174875670

This cleans the wallet_hd.py with asan.

Partial backport of core PR10740 (commit 59b87a2)
https://github.com/bitcoin/bitcoin/pull/10740/commits/59b87a27efea819e433c727756bf5fac57b33dd6

Progress towards T459
Depends on D3618

Test Plan
make check

With ASAN enabled:

./test/functional/test_runner.py wallet_hd

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Wed, Jul 10, 08:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Jul 10, 08:55
markblundeberg accepted this revision.Wed, Jul 10, 15:30
This revision is now accepted and ready to land.Wed, Jul 10, 15:30
Fabien updated this revision to Diff 10210.Wed, Jul 10, 19:04

Rebase

Fabien updated this revision to Diff 10211.Wed, Jul 10, 19:16

Better pull before rebasing...