Page MenuHomePhabricator
Differential D3629

[wallet] Fix potential memory leak in CreateWalletFromFile
ClosedPublic
Actions

Authored by Fabien on Jul 10 2019, 08:55.

Details

Reviewers
deadalnix
markblundeberg
Group Reviewers
Restricted Project
Commits
rSTAGING4c69be0a19a8: [wallet] Fix potential memory leak in CreateWalletFromFile
rABC4c69be0a19a8: [wallet] Fix potential memory leak in CreateWalletFromFile
Summary
Fix proposed by ryanofsky in
https://github.com/bitcoin/bitcoin/pull/12647#discussion_r174875670

This cleans the wallet_hd.py with asan.

Partial backport of core PR10740 (commit 59b87a2)
https://github.com/bitcoin/bitcoin/pull/10740/commits/59b87a27efea819e433c727756bf5fac57b33dd6

Progress towards T459
Depends on D3618

Test Plan
make check

With ASAN enabled:

./test/functional/test_runner.py wallet_hd

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR10740_part1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6806
Build 11659: Bitcoin ABC Buildbot (legacy)
Build 11658: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 10 2019, 08:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 10 2019, 08:55
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jul 10 2019, 08:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 10 2019, 09:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6792: Diff 10188.Jul 10 2019, 09:02
markblundeberg accepted this revision.Jul 10 2019, 15:30
This revision is now accepted and ready to land.Jul 10 2019, 15:30
Fabien updated this revision to Diff 10210.Jul 10 2019, 19:04

Rebase

teamcity added a comment.Jul 10 2019, 19:04

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B6806: Diff 10210!Jul 10 2019, 19:05
teamcity added a comment.Jul 10 2019, 19:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Fabien updated this revision to Diff 10211.Jul 10 2019, 19:16

Better pull before rebasing...

teamcity added a comment.Jul 10 2019, 19:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 10 2019, 19:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B6807: Diff 10211!Jul 10 2019, 19:18
teamcity added a comment.Jul 10 2019, 19:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 10 2019, 19:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6807: Diff 10211.Jul 10 2019, 19:29
Closed by commit rABC4c69be0a19a8: [wallet] Fix potential memory leak in CreateWalletFromFile (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyJul 10 2019, 19:34
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC4c69be0a19a8: [wallet] Fix potential memory leak in CreateWalletFromFile.
Fabien added a commit: rSTAGING4c69be0a19a8: [wallet] Fix potential memory leak in CreateWalletFromFile.Sep 19 2019, 01:10

Revision Contents
Changeset List

PathSize
src/
wallet/
279 lines

Diff 10210

View Options

src/wallet/wallet.cpp

Loading...