Page MenuHomePhabricator
Differential D3638

Merge #12988: Hold cs_main while calling UpdatedBlockTip() signal
ClosedPublic
Actions

Authored by markblundeberg on Jul 10 2019, 18:12.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING8b410f1118ea: Merge #12988: Hold cs_main while calling UpdatedBlockTip() signal
rABC8b410f1118ea: Merge #12988: Hold cs_main while calling UpdatedBlockTip() signal
Summary

PR12988 backport https://github.com/bitcoin/bitcoin/pull/12988/files
d86edd3 Hold cs_main while calling UpdatedBlockTip() and ui.NotifyBlockTip (Jesse Cohen)

D3435 was backported out of order and included the code elements from
this PR. This completes the remainder of this backport, which by now
is just comments.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12988
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6804
Build 11655: Bitcoin ABC Buildbot (legacy)
Build 11654: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jul 10 2019, 18:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 10 2019, 18:12
teamcity added a comment.Jul 10 2019, 18:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg mentioned this in T626: Backport Core PR 12988.Jul 10 2019, 18:13
Harbormaster failed remote builds in B6804: Diff 10208!Jul 10 2019, 18:20
teamcity added a comment.Jul 10 2019, 18:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

deadalnix accepted this revision.Jul 10 2019, 23:59
This revision is now accepted and ready to land.Jul 10 2019, 23:59
markblundeberg updated this revision to Diff 10236.Jul 11 2019, 18:59

retest rebase

teamcity added a comment.Jul 11 2019, 19:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6826: Diff 10236.Jul 11 2019, 19:06
teamcity added a comment.Jul 11 2019, 19:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Closed by commit rABC8b410f1118ea: Merge #12988: Hold cs_main while calling UpdatedBlockTip() signal (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJul 13 2019, 01:05
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABC8b410f1118ea: Merge #12988: Hold cs_main while calling UpdatedBlockTip() signal.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING8b410f1118ea: Merge #12988: Hold cs_main while calling UpdatedBlockTip() signal.Sep 19 2019, 01:14

Revision Contents
Changeset List

PathSize
src/
2 lines
5 lines

Diff 10208

View Options

src/validation.cpp

Loading...
View Options

src/validationinterface.cpp

Loading...