Page MenuHomePhabricator
Differential D3649

Avoid std::locale/imbue in DateTimeStrFormat
ClosedPublic
Actions

Authored by Fabien on Jul 11 2019, 07:55.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING4d4fca502dac: Avoid std::locale/imbue in DateTimeStrFormat
rABC4d4fca502dac: Avoid std::locale/imbue in DateTimeStrFormat
Summary
And replace them with just hardcoded ISO8601 strings and gmtime_r.

Pointed out by @laanwj here: #12970 (comment)

Backport of core PR12973 and PR13031
https://github.com/bitcoin/bitcoin/pull/12973/files
https://github.com/bitcoin/bitcoin/pull/13031/files

The build for MSVC is left untested and just backported "as-is". AFAIK
we don't support MSVC build and have no plan to do so, but in the event
this should occur in the future that part of code will be ready.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12973
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6818
Build 11683: Bitcoin ABC Buildbot (legacy)
Build 11682: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 11 2019, 07:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 11 2019, 07:55
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jul 11 2019, 07:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6818: Diff 10225.Jul 11 2019, 08:04
teamcity added a comment.Jul 11 2019, 08:04

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix requested changes to this revision.Jul 11 2019, 11:19

THis fix for MSVC is not backported.

This revision now requires changes to proceed.Jul 11 2019, 11:19
Fabien updated this revision to Diff 10228.Jul 11 2019, 11:31

Squashed my commits...

teamcity added a comment.Jul 11 2019, 11:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix accepted this revision.Jul 11 2019, 11:32
This revision is now accepted and ready to land.Jul 11 2019, 11:32
teamcity added a comment.Jul 11 2019, 11:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6820: Diff 10228.Jul 11 2019, 11:38
Closed by commit rABC4d4fca502dac: Avoid std::locale/imbue in DateTimeStrFormat (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by Fabien). · Explain WhyJul 11 2019, 20:03
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC4d4fca502dac: Avoid std::locale/imbue in DateTimeStrFormat.
Fabien added a commit: rSTAGING4d4fca502dac: Avoid std::locale/imbue in DateTimeStrFormat.Sep 19 2019, 01:12

Revision Contents
Changeset List

PathSize
src/
test/
17 lines
2 lines
31 lines

Diff 10225

View Options

src/test/util_tests.cpp

Loading...
View Options

src/utiltime.h

Loading...
View Options

src/utiltime.cpp

Loading...