Page MenuHomePhabricator

Avoid std::locale/imbue in DateTimeStrFormat
ClosedPublic

Authored by Fabien on Jul 11 2019, 07:55.

Details

Summary
And replace them with just hardcoded ISO8601 strings and gmtime_r.

Pointed out by @laanwj here: #12970 (comment)

Backport of core PR12973 and PR13031
https://github.com/bitcoin/bitcoin/pull/12973/files
https://github.com/bitcoin/bitcoin/pull/13031/files

The build for MSVC is left untested and just backported "as-is". AFAIK
we don't support MSVC build and have no plan to do so, but in the event
this should occur in the future that part of code will be ready.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12973
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6820
Build 11687: Bitcoin ABC Buildbot (legacy)
Build 11686: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Jul 11 2019, 11:19

THis fix for MSVC is not backported.

This revision now requires changes to proceed.Jul 11 2019, 11:19
This revision is now accepted and ready to land.Jul 11 2019, 11:32