Page MenuHomePhabricator

Merge #10793: Changing &var[0] to var.data()
ClosedPublic

Authored by nakihito on Thu, Jul 11, 21:11.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCd1cf65ab2e0d: Merge #10793: Changing &var[0] to var.data()
Summary

592404f03 Changing &vec[0] to vec.data(), what 9804 missed (MeshCollider)

Pull request description:

This just continues the work of https://github.com/bitcoin/bitcoin/pull/9804

Modifies a lot of `&vector[]`'s to `vector.data()`'s across all the files including tests, just the stuff that 9804 missed

Tree-SHA512: dd1a9dffb999dea4fba78dcc91fe02f90250db86f5c74948e1ff3e8b4036b2154b600555eaa04dece5368920aae3513bc36425dc96e4319ca1041b0928a6b656

Backport of Core PR10793
https://github.com/bitcoin/bitcoin/pull/10793/

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Thu, Jul 11, 21:11
Owners added a reviewer: Restricted Owners Package.Thu, Jul 11, 21:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Jul 11, 21:11
nakihito planned changes to this revision.Thu, Jul 11, 21:25
nakihito requested review of this revision.Mon, Jul 15, 18:16
deadalnix accepted this revision.Mon, Jul 15, 22:54
deadalnix added inline comments.
src/test/skiplist_tests.cpp
75 ↗(On Diff #10251)

That is VERY strange, but okay.

This revision is now accepted and ready to land.Mon, Jul 15, 22:54
nakihito added inline comments.Mon, Jul 15, 22:58
src/test/skiplist_tests.cpp
75 ↗(On Diff #10251)

Would it be better to revert this change? I think it looks silly, even if there could be merge conflicts.