Merge #10793: Changing &var[0] to var.data()
ClosedPublic
Actions

Authored by nakihito on Jul 11 2019, 21:11.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGd1cf65ab2e0d: Merge #10793: Changing &var[0] to var.data()
rABCd1cf65ab2e0d: Merge #10793: Changing &var[0] to var.data()

Summary

592404f03 Changing &vec[0] to vec.data(), what 9804 missed (MeshCollider)

Pull request description:

This just continues the work of https://github.com/bitcoin/bitcoin/pull/9804

Modifies a lot of `&vector[]`'s to `vector.data()`'s across all the files including tests, just the stuff that 9804 missed

Tree-SHA512: dd1a9dffb999dea4fba78dcc91fe02f90250db86f5c74948e1ff3e8b4036b2154b600555eaa04dece5368920aae3513bc36425dc96e4319ca1041b0928a6b656

Backport of Core PR10793
https://github.com/bitcoin/bitcoin/pull/10793/

Test Plan

make check
test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR10793

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6830
Build 11707: Bitcoin ABC Buildbot (legacy)
Build 11706: arc lint + arc unit

Event Timeline

nakihito created this revision.Jul 11 2019, 21:11

Owners added a reviewer: Restricted Owners Package.Jul 11 2019, 21:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 11 2019, 21:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B6830: Diff 10251!Jul 11 2019, 21:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

nakihito planned changes to this revision.Jul 11 2019, 21:25

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6830: Diff 10251.Jul 15 2019, 18:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

nakihito requested review of this revision.Jul 15 2019, 18:16

deadalnix accepted this revision.Jul 15 2019, 22:54

deadalnix added inline comments.

src/test/skiplist_tests.cpp
75	That is VERY strange, but okay.

This revision is now accepted and ready to land.Jul 15 2019, 22:54

nakihito added inline comments.Jul 15 2019, 22:58

src/test/skiplist_tests.cpp
75	Would it be better to revert this change? I think it looks silly, even if there could be merge conflicts.

Closed by commit rABCd1cf65ab2e0d: Merge #10793: Changing &var[0] to var.data() (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyJul 16 2019, 21:51

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABCd1cf65ab2e0d: Merge #10793: Changing &var[0] to var.data().

Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGd1cf65ab2e0d: Merge #10793: Changing &var[0] to var.data().Sep 19 2019, 01:19

Revision Contents
Changeset List

Path

Size

src/

qt/

signverifymessagedialog.cpp

2 lines

test/

paymentservertests.cpp

16 lines

rpc/

misc.cpp

2 lines

test/

2 lines

4 lines

46 lines

2 lines

5 lines

test_bitcoin_fuzzy.cpp

2 lines

uint256.cpp

2 lines

wallet/

crypter.cpp

16 lines

rpcwallet.cpp

2 lines

test/

wallet_crypto_tests.cpp

2 lines

Diff 10251

View Options

src/qt/signverifymessagedialog.cpp

View Options

src/qt/test/paymentservertests.cpp

View Options

src/rpc/misc.cpp

View Options

src/test/bip32_tests.cpp

View Options

src/test/bloom_tests.cpp

View Options

src/test/crypto_tests.cpp

View Options

src/test/getarg_tests.cpp

View Options

src/test/skiplist_tests.cpp

View Options

src/test/test_bitcoin_fuzzy.cpp

View Options

src/uint256.cpp

View Options

src/wallet/crypter.cpp

View Options

src/wallet/rpcwallet.cpp

View Options

src/wallet/test/wallet_crypto_tests.cpp

Merge #10793: Changing &var[0] to var.data()ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 10251

src/qt/signverifymessagedialog.cpp

src/qt/test/paymentservertests.cpp

src/rpc/misc.cpp

src/test/bip32_tests.cpp

src/test/bloom_tests.cpp

src/test/crypto_tests.cpp

src/test/getarg_tests.cpp

src/test/skiplist_tests.cpp

src/test/test_bitcoin_fuzzy.cpp

src/uint256.cpp

src/wallet/crypter.cpp

src/wallet/rpcwallet.cpp

src/wallet/test/wallet_crypto_tests.cpp

Merge #10793: Changing &var[0] to var.data()
ClosedPublic
Actions

Revision Contents
Changeset List