Page MenuHomePhabricator
Differential D3691

Fix a bug where the TeamCity build only reports one of the test_runner runs
ClosedPublic
Actions

Authored by jasonbcox on Jul 17 2019, 21:48.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING1f0ae2d1ccc9: Fix a bug where the TeamCity build only reports one of the test_runner runs
rABC1f0ae2d1ccc9: Fix a bug where the TeamCity build only reports one of the test_runner runs
Summary

The junit output of each successive test_runner.py run overwrites junit_results.xml.
This leads to a build failure, but tests reporting as passed: https://build.bitcoinabc.org/viewLog.html?buildId=16488&buildTypeId=BitcoinABC_Master_BitcoinAbcMasterAsan&tab=buildResultsDiv
It also leads to incorrect test failure reporting, making it impossible to track flaky or spurious test failures.

This diff fixes that by writing each run to it's own output file.

Test Plan

See the TeamCity build for this diff: https://build.bitcoinabc.org/viewLog.html?buildId=16722&buildTypeId=BitcoinABC_BitcoinAbcStaging&tab=testsInfo
In the "View:" dropdown, select tests without grouping by name

Diff Detail

Repository
rABC Bitcoin ABC
Branch
junitmasking
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6883
Build 11813: Bitcoin ABC Buildbot (legacy)
Build 11812: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jul 17 2019, 21:48
Herald added a reviewer: deadalnix. · View Herald TranscriptJul 17 2019, 21:48
jasonbcox planned changes to this revision.Jul 17 2019, 21:48
teamcity added a comment.Jul 17 2019, 21:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 17 2019, 21:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6883: Diff 10340.Jul 17 2019, 21:54
jasonbcox edited the summary of this revision. (Show Details)Jul 17 2019, 21:56
teamcity added a comment.Jul 17 2019, 22:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 17 2019, 22:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox requested review of this revision.Jul 17 2019, 22:08
jasonbcox edited the test plan for this revision. (Show Details)
deadalnix accepted this revision.Jul 17 2019, 23:27

ju is probably about the worse name possible.

contrib/teamcity/build.sh
90

Why is there a cutoff on master ?

This revision is now accepted and ready to land.Jul 17 2019, 23:27
jasonbcox added inline comments.Jul 18 2019, 01:25
contrib/teamcity/build.sh
90

There doesn't seem to be a rationale for it here: https://reviews.bitcoinabc.org/D1929 but it's clearly intended to run extended tests.

Closed by commit rABC1f0ae2d1ccc9: Fix a bug where the TeamCity build only reports one of the test_runner runs (authored by jasonbcox). · Explain WhyJul 18 2019, 01:26
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC1f0ae2d1ccc9: Fix a bug where the TeamCity build only reports one of the test_runner runs.
jasonbcox added a commit: rSTAGING1f0ae2d1ccc9: Fix a bug where the TeamCity build only reports one of the test_runner runs.Sep 19 2019, 01:19

Revision Contents
Changeset List

PathSize
contrib/
teamcity/
11 lines

Diff 10340

View Options

contrib/teamcity/build.sh

Loading...