Page MenuHomePhabricator
Differential D3698

Merge #11886: Clarify getbalance meaning a tiny bit in response to questions.
ClosedPublic
Actions

Authored by nakihito on Jul 19 2019, 20:39.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING9e1993a9f6f3: Merge #11886: Clarify getbalance meaning a tiny bit in response to questions.
rABC9e1993a9f6f3: Merge #11886: Clarify getbalance meaning a tiny bit in response to questions.
Summary

c79d73d Clarify getbalance meaning a tiny bit in response to questions. (Matt Corallo)

Pull request description:

Someone was asking why getbalance "*" was more "correct" than getbalance, which should rarely be true...spendzeroconfchange was the issue.

Tree-SHA512: 90201cad1acec5161aee469fb4c6d737a0eb90f8380ac93abf0e41e0f02d120afcc3e2e873e5096d3655bb63bbd16fe99e72452f308d72e69139c7f6bb2d745e

Backport of Core PR11886
https://github.com/bitcoin/bitcoin/pull/11886/

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Jul 19 2019, 20:39
Owners added a reviewer: Restricted Owners Package.Jul 19 2019, 20:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 19 2019, 20:39
teamcity added a comment.Jul 19 2019, 20:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 19 2019, 20:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6892: Diff 10358.Jul 19 2019, 20:47
deadalnix requested changes to this revision.Jul 20 2019, 00:08
deadalnix added inline comments.
src/wallet/rpcwallet.cpp
917 ↗(On Diff #10358)

The whole string is formatted such as \n are at the end of string literals, so it looks like what it is.

This revision now requires changes to proceed.Jul 20 2019, 00:08
nakihito updated this revision to Diff 10363.Jul 20 2019, 00:28

Fixed string formatting.

teamcity added a comment.Jul 20 2019, 00:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6895: Diff 10363.Jul 20 2019, 00:34
teamcity added a comment.Jul 20 2019, 00:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien accepted this revision.Jul 20 2019, 06:35
deadalnix accepted this revision.Jul 23 2019, 14:28
This revision is now accepted and ready to land.Jul 23 2019, 14:28
Closed by commit rABC9e1993a9f6f3: Merge #11886: Clarify getbalance meaning a tiny bit in response to questions. (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyJul 23 2019, 17:25
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABC9e1993a9f6f3: Merge #11886: Clarify getbalance meaning a tiny bit in response to questions..
Nico Guiton <nico@bitframe.org> added a commit: rSTAGING9e1993a9f6f3: Merge #11886: Clarify getbalance meaning a tiny bit in response to questions..Sep 19 2019, 01:23

Revision Contents
Changeset List

PathSize
src/
wallet/
4 lines

Diff 10408

View Options

src/wallet/rpcwallet.cpp

Loading...