Page MenuHomePhabricator

Don't replay the gitian initial setup at each build
ClosedPublic

Authored by Fabien on Jul 22 2019, 20:53.

Details

Summary

This diff removes the gitian setup step from the build script. This step
can be performed once at installation.

Test Plan

Run the script on CI

Diff Detail

Repository
rABC Bitcoin ABC
Branch
gitian_update_script
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6933
Build 11913: Bitcoin ABC Buildbot (legacy)
Build 11912: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jul 23 2019, 00:10

Rename URL to PROJECT_ROOT for clarity.
Move the results to the working directory so they can be removed by
Teamcity after use, avoiding disk space issues over time.

Fix gitian output relative paths.

Rebase to make the CI happy

jasonbcox requested changes to this revision.Jul 24 2019, 15:30
jasonbcox added inline comments.
contrib/teamcity/gitian.sh
4

See how TOPLEVEL is implemented in other scripts with git rev-parse. This weakens issues from assumptions that the script is run from a particular place (an assumption is still in place that the script is run within the repo, but that is reasonable enough).

This revision now requires changes to proceed.Jul 24 2019, 15:30

Don't assume the script is run from the project root.

This revision is now accepted and ready to land.Jul 24 2019, 15:55

Add missing log, move instead of copy.