Page MenuHomePhabricator
Differential D3709

Don't replay the gitian initial setup at each build
ClosedPublic
Actions

Authored by Fabien on Jul 22 2019, 20:53.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING816100f4e2ec: Don't replay the gitian initial setup at each build
rABC816100f4e2ec: Don't replay the gitian initial setup at each build
Summary

This diff removes the gitian setup step from the build script. This step
can be performed once at installation.

Test Plan

Run the script on CI

Diff Detail

Repository
rABC Bitcoin ABC
Branch
gitian_update_script
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6945
Build 11937: Bitcoin ABC Buildbot (legacy)
Build 11936: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 22 2019, 20:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 22 2019, 20:53
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jul 22 2019, 20:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 22 2019, 20:59

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Jul 22 2019, 20:59

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing failed.

Harbormaster completed remote builds in B6911: Diff 10389.Jul 22 2019, 20:59
teamcity added a comment.Jul 22 2019, 20:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

teamcity added a comment.Jul 22 2019, 21:00

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Jul 22 2019, 21:39

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing failed.

deadalnix accepted this revision.Jul 23 2019, 00:10
This revision is now accepted and ready to land.Jul 23 2019, 00:10
teamcity added a comment.Jul 23 2019, 00:52

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Jul 23 2019, 01:10

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing failed.

teamcity added a comment.Jul 23 2019, 01:23

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Jul 23 2019, 01:41

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing failed.

Fabien updated this revision to Diff 10419.Jul 24 2019, 07:33

Rename URL to PROJECT_ROOT for clarity.
Move the results to the working directory so they can be removed by
Teamcity after use, avoiding disk space issues over time.

teamcity added a comment.Jul 24 2019, 07:33

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster failed remote builds in B6931: Diff 10419!Jul 24 2019, 07:34
teamcity added a comment.Jul 24 2019, 07:34

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Fabien updated this revision to Diff 10420.Jul 24 2019, 07:35

Fix gitian output relative paths.

teamcity added a comment.Jul 24 2019, 07:35

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster failed remote builds in B6932: Diff 10420!Jul 24 2019, 07:35
teamcity added a comment.Jul 24 2019, 07:35

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Fabien updated this revision to Diff 10421.Jul 24 2019, 07:38

Rebase to make the CI happy

teamcity added a comment.Jul 24 2019, 07:38

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B6933: Diff 10421.Jul 24 2019, 07:44
teamcity added a comment.Jul 24 2019, 07:44

Build Bitcoin-ABC / Diffs / Diff Testing passed.

jasonbcox accepted this revision.Jul 24 2019, 15:27
jasonbcox requested changes to this revision.Jul 24 2019, 15:30
jasonbcox added inline comments.
contrib/teamcity/gitian.sh
4 ↗(On Diff #10421)

See how TOPLEVEL is implemented in other scripts with git rev-parse. This weakens issues from assumptions that the script is run from a particular place (an assumption is still in place that the script is run within the repo, but that is reasonable enough).

This revision now requires changes to proceed.Jul 24 2019, 15:30
Fabien updated this revision to Diff 10435.Jul 24 2019, 15:50

Don't assume the script is run from the project root.

teamcity added a comment.Jul 24 2019, 15:50

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox accepted this revision.Jul 24 2019, 15:55
This revision is now accepted and ready to land.Jul 24 2019, 15:55
teamcity added a comment.Jul 24 2019, 15:57

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B6943: Diff 10435.Jul 24 2019, 15:57
teamcity added a comment.Jul 24 2019, 16:01

Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC IBD Diff Testing (w/o checkpoints) started.

teamcity added a comment.Jul 24 2019, 16:04

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Jul 24 2019, 16:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing (Deprecated) started.

teamcity added a comment.Jul 24 2019, 16:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing (Deprecated) passed.

teamcity added a comment.Jul 24 2019, 16:51

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Jul 24 2019, 17:03

Build Bitcoin-ABC / Master / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Jul 24 2019, 17:47

Build Bitcoin-ABC / Master / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

Fabien updated this revision to Diff 10439.Jul 24 2019, 17:59

Add missing log, move instead of copy.

teamcity added a comment.Jul 24 2019, 17:59

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox accepted this revision.Jul 24 2019, 18:04
teamcity added a comment.Jul 24 2019, 18:05

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B6945: Diff 10439.Jul 24 2019, 18:05
Closed by commit rABC816100f4e2ec: Don't replay the gitian initial setup at each build (authored by Fabien). · Explain WhyJul 24 2019, 18:06
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC816100f4e2ec: Don't replay the gitian initial setup at each build.
Fabien added a commit: rSTAGING816100f4e2ec: Don't replay the gitian initial setup at each build.Sep 19 2019, 01:24

Revision Contents
Changeset List

PathSize
contrib/
teamcity/
33 lines

Diff 10439

View Options

contrib/teamcity/gitian.sh

Loading...