Page MenuHomePhabricator
Differential D3757

Use a regex to determine the list of sources for check-rpc-mappings
ClosedPublic
Actions

Authored by Fabien on Jul 29 2019, 12:51.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING54429a2bbef1: Use a regex to determine the list of sources for check-rpc-mappings
rABC54429a2bbef1: Use a regex to determine the list of sources for check-rpc-mappings
Summary

This addresses @deadalnix comment from D3751.

The script used to take a constant list to determine the source files to
be parsed. This is not ideal as it is easy to forgot to add/remove one
when the code is updated.

This diff sets the input to a list of regexes so that the parsing
remains narrow scoped while reducing the amount of maintenance for the
script.

Test Plan
time ./test/lint/check-rpc-mappings.py .

Check the output is the same, and that there is no significant
performance drop.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
check_rpc_glob
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6987
Build 12021: Bitcoin ABC Buildbot (legacy)
Build 12020: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 29 2019, 12:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 29 2019, 12:51
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jul 29 2019, 12:51

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jul 29 2019, 12:57

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B6987: Diff 10512.Jul 29 2019, 12:57
jasonbcox requested changes to this revision.Jul 31 2019, 01:18
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
test/lint/check-rpc-mappings.py
105

Is it necessary for sources to be cast to a list? Pretty sure you can iterate over a set with a foreach loop.

This revision now requires changes to proceed.Jul 31 2019, 01:18
Fabien updated this revision to Diff 10538.Jul 31 2019, 07:51

Avoid a useless cast.

teamcity added a comment.Jul 31 2019, 07:51

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien added inline comments.Jul 31 2019, 07:52
test/lint/check-rpc-mappings.py
105

Clearly it's not, good catch.

teamcity added a comment.Jul 31 2019, 07:58

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7010: Diff 10538.Jul 31 2019, 07:58
deadalnix accepted this revision.Aug 2 2019, 00:40
jasonbcox accepted this revision.Aug 5 2019, 15:46
This revision is now accepted and ready to land.Aug 5 2019, 15:46
Closed by commit rABC54429a2bbef1: Use a regex to determine the list of sources for check-rpc-mappings (authored by Fabien). · Explain WhyAug 5 2019, 16:18
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC54429a2bbef1: Use a regex to determine the list of sources for check-rpc-mappings.
Fabien added a commit: rSTAGING54429a2bbef1: Use a regex to determine the list of sources for check-rpc-mappings.Sep 19 2019, 01:37

Revision Contents
Changeset List

PathSize
test/
lint/
26 lines

Diff 10512

View Options

test/lint/check-rpc-mappings.py

Loading...