Page MenuHomePhabricator
Differential D3760

Merge #12620: Remove TransactionTableModel::TxIDRole
AbandonedPublic
Actions

Authored by nakihito on Jul 29 2019, 17:51.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

3b26b6af7 qt: Remove TransactionTableModel::TxIDRole (João Barbosa)

Pull request description:

The role `TxIDRole` is a duplicate of `TxHashRole`. This change favours `TxHashRole`.

Tree-SHA512: ad35933eae1cb6b242b25b8940d662c2c79c766732d76fdd410c80230ec084969294a8e5a126794707992a566076ef4452b592050f7af6c4fa7742891090803d

Backport of Core PR12620
https://github.com/bitcoin/bitcoin/pull/12620/

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12620
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6990
Build 12027: Bitcoin ABC Buildbot (legacy)
Build 12026: arc lint + arc unit

Event Timeline

nakihito created this revision.Jul 29 2019, 17:51
Owners added a reviewer: Restricted Owners Package.Jul 29 2019, 17:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 29 2019, 17:51
nakihito planned changes to this revision.Jul 29 2019, 17:51
teamcity added a comment.Jul 29 2019, 17:52

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jul 29 2019, 17:58

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B6990: Diff 10516.Jul 29 2019, 17:58
nakihito requested review of this revision.Jul 30 2019, 20:23
Fabien requested changes to this revision.Jul 31 2019, 07:08

I don't think this makes sense for us, as we tend to differentiate TxId and TxHash (see src/primitives/txid.h).

This revision now requires changes to proceed.Jul 31 2019, 07:08
nakihito abandoned this revision.Jul 31 2019, 17:51

Revision Contents
Changeset List

Diff 10516

View Options

src/qt/transactiondesc.cpp

Loading...
View Options

src/qt/transactiondescdialog.cpp

Loading...
View Options

src/qt/transactionfilterproxy.cpp

Loading...
View Options

src/qt/transactionrecord.h

Loading...
View Options

src/qt/transactionrecord.cpp

Loading...
View Options

src/qt/transactiontablemodel.h

Loading...
View Options

src/qt/transactiontablemodel.cpp

Loading...
View Options

src/qt/transactionview.cpp

Loading...